Trusted Entitlements: tests for signature verification without header hash#3505
Merged
Conversation
NachoSoto
commented
Dec 8, 2023
Comment on lines
+346
to
+348
| class SignatureVerificationWithoutHeaderHashIntegrationTests: EnforcedSignatureVerificationIntegrationTests { | ||
|
|
||
| override var disableHeaderSignatureVerification: Bool { return true } |
Contributor
Author
There was a problem hiding this comment.
This allows us to run all of EnforcedSignatureVerificationIntegrationTests without the new feature, so we can verify that the older SDKs continue to work.
NachoSoto
commented
Dec 8, 2023
| expect(signingRequest.parameters.message) == responseContent | ||
| expect(signingRequest.parameters.nonce) == request.nonce | ||
| expect(signingRequest.parameters.requestDate) == Self.date1.millisecondsSince1970 | ||
| expect(signingRequest.parameters.requestBody as? BodyWithSignature) == requestBody |
Contributor
Author
There was a problem hiding this comment.
We were missing a test with this.
d36a5a4 to
57f4e8a
Compare
012ebc1 to
fc18c7f
Compare
NachoSoto
commented
Dec 11, 2023
| /// Header verification (see `HTTPRequest.headerParametersForSignatureHeader`) is enabled by default, | ||
| /// but this helps verify that the backend is still signing correctly without it for older SDK versions. | ||
| /// See also `SignatureVerificationWithoutHeaderHashIntegrationTests`. | ||
| class LoadShedderSignatureVerificationWithoutHeaderHashIntegrationTests: LoadShedderStoreKit1IntegrationTests { |
Contributor
Author
There was a problem hiding this comment.
Also verifying that the load shedder continues signing these correctly.
MarkVillacampa
approved these changes
Dec 11, 2023
33a7047 to
26eb5bf
Compare
e9e027f to
513b651
Compare
26eb5bf to
730c8b5
Compare
513b651 to
ffd69f2
Compare
…er hash Follow up to #3424. This adds coverage to ensure that the backend continues to sign correctly for old SDK versions that don't support this.
ffd69f2 to
b605ecc
Compare
This was referenced Dec 21, 2023
NachoSoto
pushed a commit
that referenced
this pull request
Dec 22, 2023
**This is an automatic release.** ### RevenueCatUI * `Paywalls`: add header image to `watchOS` paywalls (#3542) via NachoSoto (@NachoSoto) * `Paywalls`: improve template 5 landscape layout (#3534) via NachoSoto (@NachoSoto) * `Paywalls`: fix template 5 footer loading view alignment (#3537) via NachoSoto (@NachoSoto) * `Paywalls`: improve template 1 landscape layout (#3532) via NachoSoto (@NachoSoto) * `Paywalls`: fix `ColorInformation.multiScheme` on `watchOS` (#3530) via NachoSoto (@NachoSoto) ### Other Changes * `Trusted Entitlements`: tests for signature verification without header hash (#3505) via NachoSoto (@NachoSoto) * `.debugRevenueCatOverlay`: added `Locale` (#3539) via NachoSoto (@NachoSoto) * `Trusted Entitlements`: add support for signing request headers (#3424) via NachoSoto (@NachoSoto) * `CI`: Add architecture to cache keys (#3538) via Mark Villacampa (@MarkVillacampa) * `Paywalls Tester`: remove double close button (#3531) via NachoSoto (@NachoSoto) * Fix `RevenueCatUI` snapshot tests (#3526) via NachoSoto (@NachoSoto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #3424. This adds coverage to ensure that the backend continues to sign correctly for old SDK versions that don't support this.