Skip to content

Paywalls: ensure footer links open in full-screen sheets#3524

Merged
NachoSoto merged 1 commit into
mainfrom
paywalls-ipad-links-2
Dec 19, 2023
Merged

Paywalls: ensure footer links open in full-screen sheets#3524
NachoSoto merged 1 commit into
mainfrom
paywalls-ipad-links-2

Conversation

@NachoSoto

Copy link
Copy Markdown
Contributor

Fixes #3518.
Follow up to #3475 and #3508.

@NachoSoto NachoSoto requested a review from a team December 18, 2023 17:55
@codecov

codecov Bot commented Dec 18, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (34e0045) 85.97% compared to head (4d4190e) 85.97%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3524   +/-   ##
=======================================
  Coverage   85.97%   85.97%           
=======================================
  Files         240      240           
  Lines       17494    17494           
=======================================
  Hits        15041    15041           
  Misses       2453     2453           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NachoSoto NachoSoto changed the base branch from main to paywalls-footer-text-alignment December 18, 2023 23:29
@NachoSoto NachoSoto changed the base branch from paywalls-footer-text-alignment to main December 18, 2023 23:29
@NachoSoto NachoSoto merged commit 84b12db into main Dec 19, 2023
@NachoSoto NachoSoto deleted the paywalls-ipad-links-2 branch December 19, 2023 16:40
NachoSoto pushed a commit that referenced this pull request Dec 20, 2023
**This is an automatic release.**

### RevenueCatUI
* `Paywalls`: add `PaywallFooterViewController` (#3486) via Toni Rico
(@tonidero)
* `Paywalls`: improve landscape support of all templates (#3471) via
NachoSoto (@NachoSoto)
* `Paywalls`: ensure footer links open in full-screen sheets (#3524) via
NachoSoto (@NachoSoto)
* `Paywalls`: improve `FooterView` text alignment (#3525) via NachoSoto
(@NachoSoto)
* Paywalls: Add dismissal method in `PaywallViewControllerDelegate`
(#3493) via Toni Rico (@tonidero)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Opening terms or privacy link from paywall opens in a sidebar on iPad

2 participants