Skip to content

Paywalls: add PaywallFooterViewController#3486

Merged
NachoSoto merged 9 commits into
mainfrom
add-paywall-footer-view-controller
Dec 19, 2023
Merged

Paywalls: add PaywallFooterViewController#3486
NachoSoto merged 9 commits into
mainfrom
add-paywall-footer-view-controller

Conversation

@tonidero

@tonidero tonidero commented Dec 4, 2023

Copy link
Copy Markdown
Contributor

Description

This adds a new PaywallFooterViewController. This VC will be used to render the footer view in the hybrids.

Comment thread Tests/TestingApps/PaywallsTester/PaywallsTester/Views/AppContentView.swift Outdated
Comment thread RevenueCatUI/UIKit/PaywallFooterViewController.swift Outdated
Comment thread RevenueCatUI/UIKit/PaywallFooterViewController.swift Outdated
Comment thread RevenueCatUI/UIKit/PaywallFooterViewController.swift Outdated
@tonidero

Copy link
Copy Markdown
Contributor Author

Will continue with this after Hack week. The current state is that I was trying to find a way to constraint the footer to just take the minimum required space before jumping to use it in the hybrids, since I think that would be required for that to work

@tonidero tonidero force-pushed the add-paywall-footer-view-controller branch from 46278f4 to 2b938b8 Compare December 11, 2023 12:47
@codecov

codecov Bot commented Dec 11, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d72ea07) 86.06% compared to head (2b938b8) 86.04%.
Report is 20 commits behind head on main.

❗ Current head 2b938b8 differs from pull request most recent head 6bf296e. Consider uploading reports for the commit 6bf296e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3486      +/-   ##
==========================================
- Coverage   86.06%   86.04%   -0.02%     
==========================================
  Files         237      237              
  Lines       17211    17211              
==========================================
- Hits        14813    14810       -3     
- Misses       2398     2401       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread RevenueCatUI/UIKit/PaywallFooterViewController.swift Outdated
Comment thread RevenueCatUI/UIKit/PaywallViewController.swift Outdated
Comment thread RevenueCatUI/UIKit/PaywallViewController.swift Outdated

@NachoSoto NachoSoto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tonidero this should be mostly ready, right?

@tonidero tonidero force-pushed the add-paywall-footer-view-controller branch from a30489f to 5c30311 Compare December 19, 2023 09:28
@tonidero

tonidero commented Dec 19, 2023

Copy link
Copy Markdown
Contributor Author

@tonidero this should be mostly ready, right?

@NachoSoto My only doubt right now is whether we need to add constraints for this to use the minimum needed space, or whether that would be in the hybrid side... But I think we can add that later if needed.

@tonidero tonidero marked this pull request as ready for review December 19, 2023 09:34
@tonidero tonidero requested a review from a team December 19, 2023 09:34
@NachoSoto NachoSoto enabled auto-merge (squash) December 19, 2023 20:33
@NachoSoto NachoSoto changed the title Paywalls: Add PaywallFooterViewController Paywalls: add PaywallFooterViewController Dec 19, 2023
@NachoSoto NachoSoto disabled auto-merge December 19, 2023 20:33
@NachoSoto NachoSoto enabled auto-merge (squash) December 19, 2023 20:33
@NachoSoto NachoSoto merged commit de31133 into main Dec 19, 2023
@NachoSoto NachoSoto deleted the add-paywall-footer-view-controller branch December 19, 2023 20:48
NachoSoto pushed a commit that referenced this pull request Dec 20, 2023
**This is an automatic release.**

### RevenueCatUI
* `Paywalls`: add `PaywallFooterViewController` (#3486) via Toni Rico
(@tonidero)
* `Paywalls`: improve landscape support of all templates (#3471) via
NachoSoto (@NachoSoto)
* `Paywalls`: ensure footer links open in full-screen sheets (#3524) via
NachoSoto (@NachoSoto)
* `Paywalls`: improve `FooterView` text alignment (#3525) via NachoSoto
(@NachoSoto)
* Paywalls: Add dismissal method in `PaywallViewControllerDelegate`
(#3493) via Toni Rico (@tonidero)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants