Skip to content

CircleCI: upgrade to Xcode 15.1#3403

Merged
NachoSoto merged 1 commit into
mainfrom
xcode-15-tests
Nov 23, 2023
Merged

CircleCI: upgrade to Xcode 15.1#3403
NachoSoto merged 1 commit into
mainfrom
xcode-15-tests

Conversation

@NachoSoto

@NachoSoto NachoSoto commented Nov 10, 2023

Copy link
Copy Markdown
Contributor

Supposedly the new image has a fix for the performance issues.

Blocked by FB13358220. Waiting on CircleCi to update to Xcode 15.1 beta 3.

@NachoSoto NachoSoto added the ci label Nov 10, 2023
@NachoSoto NachoSoto requested a review from a team November 10, 2023 17:44
NachoSoto added a commit that referenced this pull request Nov 14, 2023
[The new
image](https://discuss.circleci.com/t/xcode-15-beta-2-re-released-and-bumped-to-macos-14-1/49816)
has a fix for the [performance
issues](https://discuss.circleci.com/t/severe-performance-problems-with-xcode-15/49205/110).

This changes significantly improves performance for running
`spm-revenuecat-ui-ios-17` and the other Xcode 15 build jobs.
This fixes broken iOS 17 snapshots:
https://github.com/RevenueCat/purchases-ios-snapshots/pull/78/files

This is the same as #3403, but doesn't update `run-test-ios-17` because
that's blocked by `FB13358220`.
@NachoSoto

Copy link
Copy Markdown
Contributor Author

Will try again with Xcode 15.3 beta 3

@NachoSoto

Copy link
Copy Markdown
Contributor Author

Beta 3 fixed that issue so we can merge this when CircleCI updates the image

@NachoSoto NachoSoto enabled auto-merge (squash) November 23, 2023 02:25
@NachoSoto NachoSoto merged commit ce16a06 into main Nov 23, 2023
@NachoSoto NachoSoto deleted the xcode-15-tests branch November 23, 2023 02:46
tonidero pushed a commit that referenced this pull request Dec 1, 2023
**This is an automatic release.**

### RevenueCatUI
* `Paywalls`: remove empty space when template 4 has no offer details
(#3469) via NachoSoto (@NachoSoto)
### Other Changes
* `Concurrency`: address strict concurrency issues on `SystemInfo`
(#3462) via NachoSoto (@NachoSoto)
* `CircleCI`: upgrade to Xcode 15.1 (#3403) via NachoSoto (@NachoSoto)
* `Paywalls`: tests for `PurchaseButton` layout logic (#3468) via
NachoSoto (@NachoSoto)
* `Paywalls`: simplified `PaywallViewMode` logic (#3470) via NachoSoto
(@NachoSoto)
NachoSoto added a commit that referenced this pull request Jan 12, 2024
There is a lot of flaky failures due to bugs that have been fixed in iOS
17.

Depends on #3403, blocked by `FB13358220`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants