Skip to content

Integration Tests: run on iOS 17#3107

Merged
NachoSoto merged 1 commit into
mainfrom
integration-tests-ios-17-2
Jan 12, 2024
Merged

Integration Tests: run on iOS 17#3107
NachoSoto merged 1 commit into
mainfrom
integration-tests-ios-17-2

Conversation

@NachoSoto

@NachoSoto NachoSoto commented Aug 28, 2023

Copy link
Copy Markdown
Contributor

There is a lot of flaky failures due to bugs that have been fixed in iOS 17.

Depends on #3403, blocked by FB13358220.

@NachoSoto NachoSoto requested a review from a team August 28, 2023 15:15
@NachoSoto NachoSoto force-pushed the integration-tests-ios-17-2 branch from 3d3fad4 to 1a50e8a Compare August 28, 2023 17:55
@NachoSoto NachoSoto changed the base branch from main to nacho/fixing-integration-tests August 28, 2023 17:55
Base automatically changed from nacho/fixing-integration-tests to main August 28, 2023 18:12
@NachoSoto

Copy link
Copy Markdown
Contributor Author

We're gonna have to figure out why this isn't working:

Too long with no output (exceeded 20m0s): context deadline exceeded

@NachoSoto NachoSoto force-pushed the integration-tests-ios-17-2 branch from ba2d68e to 61c9ba9 Compare September 5, 2023 16:09
@NachoSoto NachoSoto force-pushed the integration-tests-ios-17-2 branch from 61c9ba9 to 0c58fcf Compare September 13, 2023 21:18
@NachoSoto NachoSoto changed the title Integration Tests: run on iOS 17 [WIP] Integration Tests: run on iOS 17 Sep 15, 2023
@NachoSoto NachoSoto changed the base branch from main to circleci-xcode-15-1 October 10, 2023 18:08
@NachoSoto NachoSoto force-pushed the integration-tests-ios-17-2 branch 2 times, most recently from 2c01cfd to 4593d0c Compare October 16, 2023 18:51
@NachoSoto NachoSoto changed the base branch from circleci-xcode-15-1 to circleci-xcode-15.0.1 October 16, 2023 18:52
Base automatically changed from circleci-xcode-15.0.1 to main October 16, 2023 18:56
@NachoSoto NachoSoto force-pushed the integration-tests-ios-17-2 branch from 4593d0c to 1c6b6ef Compare October 16, 2023 19:05
@NachoSoto NachoSoto marked this pull request as ready for review October 16, 2023 19:56
@NachoSoto NachoSoto changed the title [WIP] Integration Tests: run on iOS 17 Integration Tests: run on iOS 17 Oct 16, 2023
@NachoSoto

Copy link
Copy Markdown
Contributor Author

Seems like tests run reliably now!

@NachoSoto NachoSoto force-pushed the integration-tests-ios-17-2 branch 2 times, most recently from 1c6b6ef to 9124d47 Compare October 17, 2023 18:58
@NachoSoto NachoSoto changed the base branch from main to ios-17-all-tests October 17, 2023 18:58
Base automatically changed from ios-17-all-tests to main October 17, 2023 22:04
@NachoSoto NachoSoto force-pushed the integration-tests-ios-17-2 branch 2 times, most recently from da82e51 to fe5ada1 Compare October 20, 2023 21:22
@NachoSoto NachoSoto changed the base branch from main to integration-tests-repetitions-test-plan October 23, 2023 22:36
@NachoSoto NachoSoto force-pushed the integration-tests-ios-17-2 branch from fe5ada1 to 063a59c Compare October 23, 2023 22:36
Base automatically changed from integration-tests-repetitions-test-plan to main October 24, 2023 16:46
@NachoSoto NachoSoto force-pushed the integration-tests-ios-17-2 branch from 063a59c to 6c0a72e Compare October 24, 2023 19:45

@tonidero tonidero left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ready @NachoSoto ? Changes look good to me

@NachoSoto

Copy link
Copy Markdown
Contributor Author

Yeah but it's blocked by https://discuss.circleci.com/t/severe-performance-problems-with-xcode-15/49205/11
I'm hoping the next beta will make it better.
If anybody wants to approve I'll merge when they actually pass 😇

@NachoSoto NachoSoto changed the base branch from main to xcode-15-tests November 10, 2023 17:45
@NachoSoto NachoSoto force-pushed the integration-tests-ios-17-2 branch 3 times, most recently from e416403 to d544140 Compare November 10, 2023 17:52
@NachoSoto NachoSoto force-pushed the integration-tests-ios-17-2 branch from d544140 to 57d6712 Compare November 23, 2023 01:25
Base automatically changed from xcode-15-tests to main November 23, 2023 02:46
@MarkVillacampa MarkVillacampa force-pushed the integration-tests-ios-17-2 branch from 57d6712 to 626fe0c Compare December 4, 2023 16:27
@MarkVillacampa

Copy link
Copy Markdown
Member

Rebased main to see if tests finally pass on iOS 17

@NachoSoto

Copy link
Copy Markdown
Contributor Author

Thanks for checking. Looks like they're even more flaky :/

@NachoSoto NachoSoto force-pushed the integration-tests-ios-17-2 branch from 626fe0c to ad17251 Compare December 18, 2023 18:11
@NachoSoto NachoSoto force-pushed the integration-tests-ios-17-2 branch 2 times, most recently from 0c53d5b to 3c4293f Compare January 11, 2024 23:31
There is a lot of flaky failures due to bugs that have been fixed in iOS 17.
Comment thread .circleci/config.yml
xcode_version: '14.3.0'
xcode_version: '15.2'
# These tests are flaky due to FB13133387 so we don't want the noise in every PR
<<: *release-branches-and-main

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REMOVE

@NachoSoto NachoSoto force-pushed the integration-tests-ios-17-2 branch from 3c4293f to 9f28e12 Compare January 11, 2024 23:32
@NachoSoto NachoSoto removed the blocked label Jan 11, 2024
Comment thread .circleci/config.yml

backend-integration-tests-SK1:
<<: *base-job
resource_class: macos.m1.medium.gen1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CircleCI is getting rid of Intel in June. So good to migrate these early.

@NachoSoto NachoSoto force-pushed the integration-tests-ios-17-2 branch from 9f28e12 to 63c8445 Compare January 12, 2024 00:11
@NachoSoto NachoSoto enabled auto-merge (squash) January 12, 2024 00:11
@NachoSoto NachoSoto merged commit f8ff989 into main Jan 12, 2024
@NachoSoto NachoSoto deleted the integration-tests-ios-17-2 branch January 12, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants