Paywalls: added shimmer effect to LoadingPaywallView#3267
Merged
Conversation
This is a better fix than #3235. Instead of marking the view as disabled, which is also used by `PurchaseHandler` to signal that a purchase is in progress, we simply make that view not accept touches. Which has the actual effect that we want (not being interactive), without messing with how it's displayed).
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## paywalls-loading-hit-testing #3267 +/- ##
================================================================
+ Coverage 85.88% 85.93% +0.04%
================================================================
Files 233 233
Lines 16667 16667
================================================================
+ Hits 14315 14323 +8
+ Misses 2352 2344 -8 ☔ View full report in Codecov by Sentry. |
joshdholtz
approved these changes
Oct 4, 2023
Comment on lines
+158
to
+199
| private struct Shimmer: ViewModifier { | ||
|
|
||
| var duration: CGFloat | ||
| var autoreverse: Bool | ||
|
|
||
| @State | ||
| private var initialState: Bool = true | ||
|
|
||
| func body(content: Content) -> some View { | ||
| content | ||
| .mask( | ||
| LinearGradient( | ||
| gradient: .init(colors: [ | ||
| .black.opacity(0.3), | ||
| .black, | ||
| .black.opacity(0.3) | ||
| ]), | ||
| startPoint: self.startPoint, | ||
| endPoint: self.endPoint | ||
| ) | ||
| .edgesIgnoringSafeArea(.all) | ||
| ) | ||
| .onAppear { | ||
| withAnimation( | ||
| .linear(duration: self.duration) | ||
| .delay(self.duration / 2.0) | ||
| .repeatForever(autoreverses: self.autoreverse) | ||
| ) { | ||
| self.initialState.toggle() | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private var startPoint: UnitPoint { | ||
| return self.initialState ? UnitPoint(x: -0.3, y: -0.3) : UnitPoint(x: 1, y: 1) | ||
| } | ||
|
|
||
| private var endPoint: UnitPoint { | ||
| return self.initialState ? UnitPoint(x: 0, y: 0) : UnitPoint(x: 1.3, y: 1.3) | ||
| } | ||
|
|
||
| } |
NachoSoto
pushed a commit
that referenced
this pull request
Oct 4, 2023
**This is an automatic release.** ### RevenueCatUI * `Paywalls`: added shimmer effect to `LoadingPaywallView` (#3267) via NachoSoto (@NachoSoto) ### Bugfixes * `Paywalls`: fixed `macOS` compilation (#3272) via NachoSoto (@NachoSoto) ### Other Changes * Update `SwiftLint` (#3273) via NachoSoto (@NachoSoto) * PaywallsTester: allow for configuration for demos (#3260) via Andy Boedo (@aboedo) * `Paywalls`: simplified `LoadingPaywallView` (#3265) via NachoSoto (@NachoSoto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shimmer.mov