Skip to content

Paywalls: don't display progress view in LoadingPaywallView#3235

Merged
NachoSoto merged 2 commits into
mainfrom
paywalls-progress-redacted
Sep 21, 2023
Merged

Paywalls: don't display progress view in LoadingPaywallView#3235
NachoSoto merged 2 commits into
mainfrom
paywalls-progress-redacted

Conversation

@NachoSoto

@NachoSoto NachoSoto commented Sep 20, 2023

Copy link
Copy Markdown
Contributor

This got broken in #3217.

Before:

Screenshot 2023-09-20 at 15 45 50

After:

Screenshot 2023-09-20 at 15 45 22

@NachoSoto NachoSoto enabled auto-merge (squash) September 20, 2023 23:13
@NachoSoto NachoSoto merged commit 01b8eea into main Sep 21, 2023
@NachoSoto NachoSoto deleted the paywalls-progress-redacted branch September 21, 2023 02:41
NachoSoto added a commit that referenced this pull request Oct 2, 2023
This is a better fix than #3235. Instead of marking the view as disabled, which is also used by `PurchaseHandler` to signal that a purchase is in progress, we simply make that view not accept touches.
Which has the actual effect that we want (not being interactive), without messing with how it's displayed).
NachoSoto added a commit that referenced this pull request Oct 3, 2023
This is a better fix than #3235. Instead of marking the view as
disabled, which is also used by `PurchaseHandler` to signal that a
purchase is in progress, we simply make that view not accept touches.

Which has the actual effect that we want (not being interactive),
without messing with how it's displayed).

![Screenshot 2023-10-02 at 14 04
49](https://github.com/RevenueCat/purchases-ios/assets/685609/049a1931-8e71-4875-b297-c00562d318e6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants