CI: add workaround for Carthage timing out#3119
Merged
Merged
Conversation
`xcodebuild -list` loads all SPM dependencies, which includes our own repo (necessary to test `RevenueCat_CustomEntitlementComputation`): ``` Resolve Package Graph Resolve Package Graph Resolved source packages: CwlPreconditionTesting: https://github.com/mattgallagher/CwlPreconditionTesting.git @ 2.1.2 swift-snapshot-testing: https://github.com/pointfreeco/swift-snapshot-testing @ 1.11.1 CwlCatchException: https://github.com/mattgallagher/CwlCatchException.git @ 2.1.2 Nimble: https://github.com/quick/nimble @ 10.0.0 OHHTTPStubs: https://github.com/AliSoftware/OHHTTPStubs.git @ 9.1.0 RevenueCat: https://github.com/RevenueCat/purchases-ios @ main ``` `Carthage` has as [hardcoded timeout of 60 seconds](https://github.com/Carthage/Carthage/blob/0.39.0/Source/CarthageKit/XCDBLDExtensions.swift#L79). This has been failing ti due to our repo size growing combined with CircleCI's network issues. To prevent that, this updates all lanes that use `Carthage` to pre-load SPM dependencies by calling `xcodebuild -list` first.
NachoSoto
commented
Aug 29, 2023
95a68df to
f94d0a5
Compare
Codecov Report
@@ Coverage Diff @@
## main #3119 +/- ##
==========================================
- Coverage 86.62% 86.62% -0.01%
==========================================
Files 219 219
Lines 15683 15683
==========================================
- Hits 13586 13585 -1
- Misses 2097 2098 +1 |
aboedo
approved these changes
Aug 30, 2023
NachoSoto
added a commit
that referenced
this pull request
Aug 31, 2023
`xcodebuild -list` loads all SPM dependencies, which includes our own repo (necessary to test `RevenueCat_CustomEntitlementComputation`): ``` Resolve Package Graph Resolve Package Graph Resolved source packages: CwlPreconditionTesting: https://github.com/mattgallagher/CwlPreconditionTesting.git @ 2.1.2 swift-snapshot-testing: https://github.com/pointfreeco/swift-snapshot-testing @ 1.11.1 CwlCatchException: https://github.com/mattgallagher/CwlCatchException.git @ 2.1.2 Nimble: https://github.com/quick/nimble @ 10.0.0 OHHTTPStubs: https://github.com/AliSoftware/OHHTTPStubs.git @ 9.1.0 RevenueCat: https://github.com/RevenueCat/purchases-ios @ main ``` `Carthage` has as [hardcoded timeout of 60 seconds](https://github.com/Carthage/Carthage/blob/0.39.0/Source/CarthageKit/XCDBLDExtensions.swift#L79). This has been failing ti due to our repo size growing combined with CircleCI's network issues. To prevent that, this updates all lanes that use `Carthage` to pre-load SPM dependencies by calling `xcodebuild -list` first.
This was referenced Aug 31, 2023
NachoSoto
added a commit
that referenced
this pull request
Sep 1, 2023
Follow up to #3119. This job also needed the workaround to make sure `Carthage` doesn't time out. Also moved the implementation to Fastlane.
This was referenced Sep 5, 2023
NachoSoto
pushed a commit
that referenced
this pull request
Sep 5, 2023
**This is an automatic release.** ### Bugfixes * `DebugViewModel`: fixed runtime crash on iOS < 16 (#3139) via NachoSoto (@NachoSoto) ### Performance Improvements * `PurchasesOrchestrator`: return early if receipt has no transactions when checking for promo offers (#3123) via Mark Villacampa (@MarkVillacampa) * `Purchases`: don't clear intro eligibility / purchased products cache on first launch (#3067) via NachoSoto (@NachoSoto) ### Dependency Updates * `SPM`: update `Package.resolved` (#3130) via NachoSoto (@NachoSoto) ### Other Changes * `ReceiptParser`: fixed SPM build (#3144) via NachoSoto (@NachoSoto) * `carthage_installation_tests`: optimize SPM package loading (#3129) via NachoSoto (@NachoSoto) * `CI`: add workaround for `Carthage` timing out (#3119) via NachoSoto (@NachoSoto) * `Integration Tests`: workaround to not lose debug logs (#3108) via NachoSoto (@NachoSoto)
MarkVillacampa
pushed a commit
that referenced
this pull request
Sep 6, 2023
`xcodebuild -list` loads all SPM dependencies, which includes our own repo (necessary to test `RevenueCat_CustomEntitlementComputation`): ``` Resolve Package Graph Resolve Package Graph Resolved source packages: CwlPreconditionTesting: https://github.com/mattgallagher/CwlPreconditionTesting.git @ 2.1.2 swift-snapshot-testing: https://github.com/pointfreeco/swift-snapshot-testing @ 1.11.1 CwlCatchException: https://github.com/mattgallagher/CwlCatchException.git @ 2.1.2 Nimble: https://github.com/quick/nimble @ 10.0.0 OHHTTPStubs: https://github.com/AliSoftware/OHHTTPStubs.git @ 9.1.0 RevenueCat: https://github.com/RevenueCat/purchases-ios @ main ``` `Carthage` has as [hardcoded timeout of 60 seconds](https://github.com/Carthage/Carthage/blob/0.39.0/Source/CarthageKit/XCDBLDExtensions.swift#L79). This has been failing ti due to our repo size growing combined with CircleCI's network issues. To prevent that, this updates all lanes that use `Carthage` to pre-load SPM dependencies by calling `xcodebuild -list` first.
MarkVillacampa
pushed a commit
that referenced
this pull request
Sep 6, 2023
Follow up to #3119. This job also needed the workaround to make sure `Carthage` doesn't time out. Also moved the implementation to Fastlane.
MarkVillacampa
pushed a commit
that referenced
this pull request
Sep 6, 2023
**This is an automatic release.** ### Bugfixes * `DebugViewModel`: fixed runtime crash on iOS < 16 (#3139) via NachoSoto (@NachoSoto) ### Performance Improvements * `PurchasesOrchestrator`: return early if receipt has no transactions when checking for promo offers (#3123) via Mark Villacampa (@MarkVillacampa) * `Purchases`: don't clear intro eligibility / purchased products cache on first launch (#3067) via NachoSoto (@NachoSoto) ### Dependency Updates * `SPM`: update `Package.resolved` (#3130) via NachoSoto (@NachoSoto) ### Other Changes * `ReceiptParser`: fixed SPM build (#3144) via NachoSoto (@NachoSoto) * `carthage_installation_tests`: optimize SPM package loading (#3129) via NachoSoto (@NachoSoto) * `CI`: add workaround for `Carthage` timing out (#3119) via NachoSoto (@NachoSoto) * `Integration Tests`: workaround to not lose debug logs (#3108) via NachoSoto (@NachoSoto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xcodebuild -listloads all SPM dependencies, which includes our own repo (necessary to testRevenueCat_CustomEntitlementComputation):Carthagehas as hardcoded timeout of 60 seconds. This has been failing ti due to our repo size growing combined with CircleCI's network issues.To prevent that, this updates all lanes that use
Carthageto pre-load SPM dependencies by callingxcodebuild -listfirst.