Integration Tests: workaround to not lose debug logs#3108
Merged
Conversation
08b832d to
b2541f1
Compare
NachoSoto
commented
Aug 28, 2023
Comment on lines
52
to
54
Contributor
Author
There was a problem hiding this comment.
This file is now in ReceiptParser, which doesn't have Strings+Extensions.
b2541f1 to
8c58944
Compare
Codecov Report
@@ Coverage Diff @@
## main #3108 +/- ##
==========================================
+ Coverage 86.60% 86.62% +0.01%
==========================================
Files 219 219
Lines 15683 15683
==========================================
+ Hits 13583 13586 +3
+ Misses 2100 2097 -3 |
NachoSoto
commented
Aug 29, 2023
`OSLogType.debug` logs are purged and not saved: > The system only captures debug-level messages in memory when you enable debug logging through a configuration change, and purges them in accordance with the configuration’s persistence setting. I haven't been able to find a way to override this behavior. This means than when reading the logs on CI or when downloading the `xcresult` archive, we can't see these, making it really hard to debug failures.
1541fbe to
d2fe01a
Compare
tonidero
approved these changes
Aug 30, 2023
NachoSoto
added a commit
that referenced
this pull request
Sep 5, 2023
This was wrong in #3108. `ProcessInfo+Extensions` was added to the `ReceiptParser` target, but not when building through SPM. This fixes that.
NachoSoto
added a commit
that referenced
this pull request
Sep 5, 2023
This was wrong in #3108. `ProcessInfo+Extensions` was added to the `ReceiptParser` target, but not when building through SPM. This fixes that. We didn't catch this with the `spm-receipt-parser` CI job because that does a release build.
NachoSoto
pushed a commit
that referenced
this pull request
Sep 5, 2023
**This is an automatic release.** ### Bugfixes * `DebugViewModel`: fixed runtime crash on iOS < 16 (#3139) via NachoSoto (@NachoSoto) ### Performance Improvements * `PurchasesOrchestrator`: return early if receipt has no transactions when checking for promo offers (#3123) via Mark Villacampa (@MarkVillacampa) * `Purchases`: don't clear intro eligibility / purchased products cache on first launch (#3067) via NachoSoto (@NachoSoto) ### Dependency Updates * `SPM`: update `Package.resolved` (#3130) via NachoSoto (@NachoSoto) ### Other Changes * `ReceiptParser`: fixed SPM build (#3144) via NachoSoto (@NachoSoto) * `carthage_installation_tests`: optimize SPM package loading (#3129) via NachoSoto (@NachoSoto) * `CI`: add workaround for `Carthage` timing out (#3119) via NachoSoto (@NachoSoto) * `Integration Tests`: workaround to not lose debug logs (#3108) via NachoSoto (@NachoSoto)
MarkVillacampa
pushed a commit
that referenced
this pull request
Sep 6, 2023
MarkVillacampa
pushed a commit
that referenced
this pull request
Sep 6, 2023
This was wrong in #3108. `ProcessInfo+Extensions` was added to the `ReceiptParser` target, but not when building through SPM. This fixes that. We didn't catch this with the `spm-receipt-parser` CI job because that does a release build.
MarkVillacampa
pushed a commit
that referenced
this pull request
Sep 6, 2023
**This is an automatic release.** ### Bugfixes * `DebugViewModel`: fixed runtime crash on iOS < 16 (#3139) via NachoSoto (@NachoSoto) ### Performance Improvements * `PurchasesOrchestrator`: return early if receipt has no transactions when checking for promo offers (#3123) via Mark Villacampa (@MarkVillacampa) * `Purchases`: don't clear intro eligibility / purchased products cache on first launch (#3067) via NachoSoto (@NachoSoto) ### Dependency Updates * `SPM`: update `Package.resolved` (#3130) via NachoSoto (@NachoSoto) ### Other Changes * `ReceiptParser`: fixed SPM build (#3144) via NachoSoto (@NachoSoto) * `carthage_installation_tests`: optimize SPM package loading (#3129) via NachoSoto (@NachoSoto) * `CI`: add workaround for `Carthage` timing out (#3119) via NachoSoto (@NachoSoto) * `Integration Tests`: workaround to not lose debug logs (#3108) via NachoSoto (@NachoSoto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OSLogType.debuglogs are purged and not saved:I haven't been able to find a way to override this behavior. This means than when reading the logs on CI or when downloading the
xcresultarchive, we can't see these, making it really hard to debug failures.See also #3048.