StoreKit 2: added warning to paywall constructors#3045
Merged
Conversation
This became a requirement with #3032.
tonidero
reviewed
Aug 18, 2023
| /// the result automatically. All you need to do is to dismiss the paywall | ||
| /// the result automatically. All you need to do is to dismiss the paywall. | ||
| /// | ||
| /// - Warning: In order to use StoreKit paywalls you must configure the `RevenueCat` SDK |
Contributor
There was a problem hiding this comment.
I haven't been tracking the Paywall changes, but would it make sense to log an error if a user tries to display the paywall using SK1? I was also thinking of actually erroring out, but not sure how that would work, so a log might be enough.
Contributor
Author
There was a problem hiding this comment.
tonidero
approved these changes
Aug 18, 2023
NachoSoto
pushed a commit
that referenced
this pull request
Aug 23, 2023
**This is an automatic release.** ### Other Changes * `Integration Tests`: test that `checkTrialOrIntroDiscountEligibility` makes no API requests (#3054) via NachoSoto (@NachoSoto) * `visionOS`: changed CI job to Release (#3042) via NachoSoto (@NachoSoto) * `StoreKit 2`: added warning to paywall constructors (#3045) via NachoSoto (@NachoSoto) * `README`: added `visionOS` to list of supported platforms (#3052) via NachoSoto (@NachoSoto) * `Tests`: added tests for `ClockType` (#3029) via NachoSoto (@NachoSoto) * `HTTPClient`: also parse errors with `application/json;charset=utf8` (#3041) via NachoSoto (@NachoSoto)
MarkVillacampa
pushed a commit
that referenced
this pull request
Sep 6, 2023
This became a requirement with #3032.
MarkVillacampa
pushed a commit
that referenced
this pull request
Sep 6, 2023
**This is an automatic release.** ### Other Changes * `Integration Tests`: test that `checkTrialOrIntroDiscountEligibility` makes no API requests (#3054) via NachoSoto (@NachoSoto) * `visionOS`: changed CI job to Release (#3042) via NachoSoto (@NachoSoto) * `StoreKit 2`: added warning to paywall constructors (#3045) via NachoSoto (@NachoSoto) * `README`: added `visionOS` to list of supported platforms (#3052) via NachoSoto (@NachoSoto) * `Tests`: added tests for `ClockType` (#3029) via NachoSoto (@NachoSoto) * `HTTPClient`: also parse errors with `application/json;charset=utf8` (#3041) via NachoSoto (@NachoSoto)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3045 +/- ##
==========================================
- Coverage 86.65% 86.65% -0.01%
==========================================
Files 219 219
Lines 15667 15667
==========================================
- Hits 13577 13576 -1
- Misses 2090 2091 +1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This became a requirement with #3032.