visionOS: changed CI job to Release#3042
Merged
Merged
Conversation
The `build_tv_watch_mac` job already builds on Release mode (`Carthage`'s default). This would have also helped detect the issue fixed by #3034. I've also changed the API tester jobs to compile on release, though those aren't ran by CI.
tonidero
approved these changes
Aug 18, 2023
| scheme: 'SwiftAPITester', | ||
| destination: 'generic/platform=iOS Simulator' | ||
| destination: 'generic/platform=iOS Simulator', | ||
| configuration: 'release', |
Contributor
There was a problem hiding this comment.
I wonder if we should build the api tests in both debug and release, in case we have any debug-only apis... I agree release is more important though, so this makes sense.
Contributor
Author
There was a problem hiding this comment.
We compile API testers in debug when running tests.
NachoSoto
pushed a commit
that referenced
this pull request
Aug 23, 2023
**This is an automatic release.** ### Other Changes * `Integration Tests`: test that `checkTrialOrIntroDiscountEligibility` makes no API requests (#3054) via NachoSoto (@NachoSoto) * `visionOS`: changed CI job to Release (#3042) via NachoSoto (@NachoSoto) * `StoreKit 2`: added warning to paywall constructors (#3045) via NachoSoto (@NachoSoto) * `README`: added `visionOS` to list of supported platforms (#3052) via NachoSoto (@NachoSoto) * `Tests`: added tests for `ClockType` (#3029) via NachoSoto (@NachoSoto) * `HTTPClient`: also parse errors with `application/json;charset=utf8` (#3041) via NachoSoto (@NachoSoto)
MarkVillacampa
pushed a commit
that referenced
this pull request
Sep 6, 2023
MarkVillacampa
pushed a commit
that referenced
this pull request
Sep 6, 2023
**This is an automatic release.** ### Other Changes * `Integration Tests`: test that `checkTrialOrIntroDiscountEligibility` makes no API requests (#3054) via NachoSoto (@NachoSoto) * `visionOS`: changed CI job to Release (#3042) via NachoSoto (@NachoSoto) * `StoreKit 2`: added warning to paywall constructors (#3045) via NachoSoto (@NachoSoto) * `README`: added `visionOS` to list of supported platforms (#3052) via NachoSoto (@NachoSoto) * `Tests`: added tests for `ClockType` (#3029) via NachoSoto (@NachoSoto) * `HTTPClient`: also parse errors with `application/json;charset=utf8` (#3041) via NachoSoto (@NachoSoto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
build_tv_watch_macjob already builds on Release mode (Carthage's default).This would have also helped detect the issue fixed by #3034.
I've also changed the API tester jobs to compile on release, though those aren't ran by CI.