xrOS: fixed SubscriptionStoreView for visionOS beta 2#2884
Merged
Conversation
xrOS: fixed `` for visionOS beta 2xrOS: fixed SubscriptionStoreView for visionOS beta 2
Codecov Report
@@ Coverage Diff @@
## main #2884 +/- ##
==========================================
- Coverage 86.61% 86.60% -0.01%
==========================================
Files 217 217
Lines 15514 15514
==========================================
- Hits 13437 13436 -1
- Misses 2077 2078 +1 |
xrOS: fixed SubscriptionStoreView for visionOS beta 2xrOS: fixed SubscriptionStoreView for visionOS beta 2
Contributor
|
Thanks for doing this! |
NachoSoto
reviewed
Jul 26, 2023
| #if os(xrOS) | ||
| @available(iOS 17.0, macOS 14.0, tvOS 17.0, watchOS 10.0, *) | ||
| extension SubscriptionStoreView where Content == DefaultSubscriptionStoreMarketingContent { | ||
| extension SubscriptionStoreView where Content == AutomaticSubscriptionStoreMarketingContent { |
Contributor
There was a problem hiding this comment.
This is now in sync with the iOS version below, so I'm going to remove the #if.
NachoSoto
approved these changes
Jul 26, 2023
NachoSoto
left a comment
Contributor
There was a problem hiding this comment.
SDK does build. I'll fix test compilation separately.
NachoSoto
added a commit
that referenced
this pull request
Jul 26, 2023
**This is an automatic release.** _This release is compatible with Xcode 15 beta 5 and visionOS beta 2_ ### Bugfixes * `xrOS`: fixed `SubscriptionStoreView` for visionOS beta 2 (#2884) via Josh Holtz (@joshdholtz) ### Performance Improvements * `Perf`: update `CustomerInfo` cache before anything else (#2865) via NachoSoto (@NachoSoto) ### Other Changes * `SimpleApp`: added support for localization (#2880) via NachoSoto (@NachoSoto) * `TestStoreProduct`: made available on release builds (#2861) via NachoSoto (@NachoSoto) * `Tests`: increased default logger capacity (#2870) via NachoSoto (@NachoSoto) * `CustomEntitlementComputation`: removed `invalidateCustomerInfoCache` (#2866) via NachoSoto (@NachoSoto) * `SimpleApp`: updates for TestFlight compatibility (#2862) via NachoSoto (@NachoSoto) * `BasePurchasesTests`: consolidate to only initialize one `DeviceCache` (#2863) via NachoSoto (@NachoSoto) * `Codable`: debug log entire JSON when decoding fails (#2864) via NachoSoto (@NachoSoto) * `IntegrationTests`: replaced `Purchases.shared` with a `throw`ing property (#2867) via NachoSoto (@NachoSoto) * `NetworkError`: 2 new tests to ensure underlying error is included in description (#2843) via NachoSoto (@NachoSoto) * Add SPM `Package.resolved` for Xcode Cloud (#2844) via NachoSoto (@NachoSoto) * `CustomEntitlementComputation`: added integration test for cancellations (#2849) via NachoSoto (@NachoSoto) * `CustomEntitlementComputation`: removed `syncPurchases`/`restorePurchases` (#2854) via NachoSoto (@NachoSoto) --------- Co-authored-by: NachoSoto <ignaciosoto90@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
visionOS beta 2 had compile errors in
SubscriptionStoreViewDescription
Replaced
DefaultSubscriptionStoreMarketingContentwithAutomaticSubscriptionStoreMarketingContent