Skip to content

Add SPM Package.resolved for Xcode Cloud#2844

Merged
NachoSoto merged 2 commits into
mainfrom
xcode-cloud
Jul 23, 2023
Merged

Add SPM Package.resolved for Xcode Cloud#2844
NachoSoto merged 2 commits into
mainfrom
xcode-cloud

Conversation

@NachoSoto

@NachoSoto NachoSoto commented Jul 20, 2023

Copy link
Copy Markdown
Contributor

This is required for Xcode Cloud:

a resolved file is required when automatic dependency resolution is disabled and should be placed at /Volumes/workspace/repository/RevenueCat.xcworkspace/xcshareddata/swiftpm/Package.resolved. Running resolver because the following dependencies were added: 'purchases-ios' (https://github.com/RevenueCat/purchases-ios)fatalError

@NachoSoto NachoSoto added the ci label Jul 20, 2023
@NachoSoto NachoSoto requested a review from a team July 20, 2023 07:17
@codecov

codecov Bot commented Jul 20, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2844 (4519a20) into main (8a70941) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 4519a20 differs from pull request most recent head 7668156. Consider uploading reports for the commit 7668156 to get more accurate results

@@            Coverage Diff             @@
##             main    #2844      +/-   ##
==========================================
- Coverage   86.57%   86.55%   -0.02%     
==========================================
  Files         217      217              
  Lines       15513    15513              
==========================================
- Hits        13430    13428       -2     
- Misses       2083     2085       +2     

see 4 files with indirect coverage changes

@tonidero tonidero left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it this one: https://github.com/RevenueCat/purchases-ios/blob/main/.gitignore#L40? Not sure... I'm not that familiar with SPM, but this looks good

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing linking to a target doesn't happen here (so as not to include testing libraries in the output library)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is simply listing what dependencies are in the project. Which targets link to them is specified in either SPM or the targets :)

@NachoSoto

Copy link
Copy Markdown
Contributor Author

OMG yes! I was looking for xcshareddata. I'll update the .gitignore.

Comment thread .gitignore
IntegrationTests/CarthageInstallation/Cartfile.resolved
scan_derived_data/
generated_docs/
**/Package.resolved

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it to this, so examples / tests still don't have it any force resolution during CI.

@NachoSoto NachoSoto enabled auto-merge (squash) July 21, 2023 06:29
@NachoSoto NachoSoto merged commit aea0114 into main Jul 23, 2023
@NachoSoto NachoSoto deleted the xcode-cloud branch July 23, 2023 18:20
NachoSoto added a commit that referenced this pull request Jul 26, 2023
**This is an automatic release.**

_This release is compatible with Xcode 15 beta 5 and visionOS beta 2_

### Bugfixes
* `xrOS`: fixed `SubscriptionStoreView` for visionOS beta 2 (#2884) via
Josh Holtz (@joshdholtz)
### Performance Improvements
* `Perf`: update `CustomerInfo` cache before anything else (#2865) via
NachoSoto (@NachoSoto)
### Other Changes
* `SimpleApp`: added support for localization (#2880) via NachoSoto
(@NachoSoto)
* `TestStoreProduct`: made available on release builds (#2861) via
NachoSoto (@NachoSoto)
* `Tests`: increased default logger capacity (#2870) via NachoSoto
(@NachoSoto)
* `CustomEntitlementComputation`: removed `invalidateCustomerInfoCache`
(#2866) via NachoSoto (@NachoSoto)
* `SimpleApp`: updates for TestFlight compatibility (#2862) via
NachoSoto (@NachoSoto)
* `BasePurchasesTests`: consolidate to only initialize one `DeviceCache`
(#2863) via NachoSoto (@NachoSoto)
* `Codable`: debug log entire JSON when decoding fails (#2864) via
NachoSoto (@NachoSoto)
* `IntegrationTests`: replaced `Purchases.shared` with a `throw`ing
property (#2867) via NachoSoto (@NachoSoto)
* `NetworkError`: 2 new tests to ensure underlying error is included in
description (#2843) via NachoSoto (@NachoSoto)
* Add SPM `Package.resolved` for Xcode Cloud (#2844) via NachoSoto
(@NachoSoto)
* `CustomEntitlementComputation`: added integration test for
cancellations (#2849) via NachoSoto (@NachoSoto)
* `CustomEntitlementComputation`: removed
`syncPurchases`/`restorePurchases` (#2854) via NachoSoto (@NachoSoto)

---------

Co-authored-by: NachoSoto <ignaciosoto90@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants