Custom Entitlement Computation: disabled unnecessary APIs by NachoSoto · Pull Request #2442 · RevenueCat/purchases-ios

NachoSoto · 2023-04-25T20:22:04Z

Disabled API:

getCustomerInfo
logIn
logOut
Purchases.attribution
syncPurchases
restorePurchases
Trial eligibility
Promotional purchases
async counterparts

NachoSoto · 2023-04-25T20:27:28Z

We know this at compile time now.

NachoSoto · 2023-04-25T22:23:50Z

This can't happen anymore.

NachoSoto · 2023-04-25T22:37:11Z

I want to make sure the new SPM installation test is still working with this (since the job only runs on release branches)

aboedo

only thing is enabling getOfferings

aboedo · 2023-04-25T22:48:02Z

we can probably group this one and the one for (self as DeprecatedSearchAdsAttribution).postAppleSearchAddsAttributionCollectionIfNeeded() a few lines above into one, since this method is only called from there, right?

This is also called from applicationWillResignActive.

aboedo · 2023-04-25T22:54:10Z

getOfferings didn't make the cut here but it should be enabled

NachoSoto · 2023-04-26T06:14:34Z

Updated to enable getOfferings.

…on API

tonidero

Should we have separate API tests for the new package? To make sure the APIs we are exposing there don't change. I guess that can be done in a different PR though.

tonidero · 2023-04-26T07:57:55Z

        }
    }

+    #endif


It reads a bit strange that this endif is not indented at the same level as the following line... NABD though.

Yeah, the default indentation by Xcode is even worse, it always moves # lines to the very left.

NachoSoto · 2023-04-26T14:51:57Z

Should we have separate API tests for the new package?

I'm going to do that today in a separate PR, but that doesn't have to block the release.

NachoSoto · 2023-04-26T15:10:39Z

TODO: also hide purchase with promotional offer methods /cc @aboedo

tonidero · 2023-04-26T15:56:38Z

Hid the promotional offer purchase methods in #2448

…ge (#2448) ### Description This will remove the `promotionaOffer` purchase methods from the API in the custom entitlement computation package

…rInfoStream (#2446) fixes resubscribes to customerInfoStream in the CustomEntitlementsComputation sample app

aboedo

we should re-enable restore and sync purchases before shipping, but it can be a separate PR

aboedo · 2023-04-26T17:51:02Z

+#if !ENABLE_CUSTOM_ENTITLEMENT_COMPUTATION
 @available(iOS 13.0, macOS 10.15, tvOS 13.0, watchOS 6.2, *)


good catch on this one

NachoSoto · 2023-04-26T17:52:17Z

Not I was gonna do it here haha, I forgot I had the auto merge.

…chases` Follow up to #2442

…chases` (#2451) Follow up to #2442

## Disabled API: - `getCustomerInfo` - `logIn` - `logOut` - `Purchases.attribution` - `syncPurchases` - `restorePurchases` - Trial eligibility - Promotional purchases - `async` counterparts --------- Co-authored-by: Toni Rico <antonio.rico.diez@revenuecat.com>

…chases` (#2451) Follow up to #2442

For some reason the existing command was failing, but CI was ignoring that failure. This moves the job to our `Fastfile`, and fixes compilation. That API was removed in #2442.

NachoSoto added the refactor label Apr 25, 2023

NachoSoto requested a review from a team April 25, 2023 20:22

NachoSoto force-pushed the spm-custom-entitlements branch from c96ddc6 to da51d52 Compare April 25, 2023 20:22

NachoSoto force-pushed the custom-entitlement-disabled-api branch from 45895ca to 2ff5221 Compare April 25, 2023 20:22

NachoSoto commented Apr 25, 2023

View reviewed changes

NachoSoto force-pushed the custom-entitlement-disabled-api branch 2 times, most recently from 71ad769 to a4f87e7 Compare April 25, 2023 20:51

NachoSoto mentioned this pull request Apr 25, 2023

customEntitlementsComputation: update the copy in the sample app to explain the new usage #2443

Merged

NachoSoto force-pushed the spm-custom-entitlements branch from 63c9a6c to 9c406cd Compare April 25, 2023 20:56

NachoSoto force-pushed the custom-entitlement-disabled-api branch from a70e30d to cca5cc3 Compare April 25, 2023 20:57

NachoSoto mentioned this pull request Apr 25, 2023

Create separate SPM library to enable custom entitlement computation #2440

Merged

Base automatically changed from spm-custom-entitlements to main April 25, 2023 22:12

NachoSoto force-pushed the custom-entitlement-disabled-api branch from 0979a4d to 9c9b13d Compare April 25, 2023 22:22

NachoSoto commented Apr 25, 2023

View reviewed changes

aboedo requested changes Apr 25, 2023

View reviewed changes

NachoSoto force-pushed the custom-entitlement-disabled-api branch from 9c9b13d to 74333a2 Compare April 26, 2023 06:13

NachoSoto requested a review from aboedo April 26, 2023 06:17

NachoSoto force-pushed the custom-entitlement-disabled-api branch from f6764ff to c86c222 Compare April 26, 2023 06:17

Custom Entitlement Computation: disabled authentication and attributi…

c327bf3

…on API

NachoSoto force-pushed the custom-entitlement-disabled-api branch from c86c222 to c327bf3 Compare April 26, 2023 06:34

NachoSoto mentioned this pull request Apr 26, 2023

[DO NOT MERGE] Release/4.18.0 #2445

Closed

tonidero approved these changes Apr 26, 2023

View reviewed changes

Hide promotional offers APIs in custom entitlements computation packa…

9e82126

…ge (#2448) ### Description This will remove the `promotionaOffer` purchase methods from the API in the custom entitlement computation package

NachoSoto enabled auto-merge (squash) April 26, 2023 16:08

NachoSoto disabled auto-merge April 26, 2023 16:08

NachoSoto changed the title ~~Custom Entitlement Computation: disabled authentication and attribution API~~ Custom Entitlement Computation: disabled unnecessary APIs Apr 26, 2023

NachoSoto enabled auto-merge (squash) April 26, 2023 16:08

CustomEntitlementsComputation sample app: fix resubscribes to custome…

0c9b340

…rInfoStream (#2446) fixes resubscribes to customerInfoStream in the CustomEntitlementsComputation sample app

aboedo approved these changes Apr 26, 2023

View reviewed changes

NachoSoto merged commit 4a74d33 into main Apr 26, 2023

NachoSoto deleted the custom-entitlement-disabled-api branch April 26, 2023 17:51

NachoSoto added a commit that referenced this pull request Apr 26, 2023

Custom Entitlement Computation: re-enable syncPurchases/`restorePur…

a996f84

…chases` Follow up to #2442

NachoSoto mentioned this pull request Apr 26, 2023

Custom Entitlement Computation: re-enable syncPurchases/restorePurchases #2451

Merged

NachoSoto added a commit that referenced this pull request Apr 26, 2023

Custom Entitlement Computation: re-enable syncPurchases/`restorePur…

853ea0f

…chases` (#2451) Follow up to #2442

NachoSoto added a commit that referenced this pull request Apr 26, 2023

Custom Entitlement Computation: re-enable syncPurchases/`restorePur…

62d2c3c

…chases` (#2451) Follow up to #2442

RCGitBot mentioned this pull request May 3, 2023

[AUTOMATIC] Release/4.19.0 #2466

Closed

NachoSoto mentioned this pull request Jul 14, 2023

CustomEntitlementsComputation: fixed API testers #2815

Merged

                       }
                   }
+                  #endif

		#if !ENABLE_CUSTOM_ENTITLEMENT_COMPUTATION
		@available(iOS 13.0, macOS 10.15, tvOS 13.0, watchOS 6.2, *)

Conversation

NachoSoto commented Apr 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Disabled API:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NachoSoto commented Apr 25, 2023

Uh oh!

aboedo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NachoSoto commented Apr 26, 2023

Uh oh!

tonidero left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NachoSoto commented Apr 26, 2023

Uh oh!

NachoSoto commented Apr 26, 2023

Uh oh!

tonidero commented Apr 26, 2023

Uh oh!

aboedo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NachoSoto commented Apr 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NachoSoto commented Apr 25, 2023 •

edited

Loading