Hide promotional offers APIs in custom entitlements computation package#2448
Merged
tonidero merged 2 commits intoApr 26, 2023
Merged
Conversation
tonidero
commented
Apr 26, 2023
tonidero
left a comment
Contributor
Author
There was a problem hiding this comment.
I thought about hiding the promotional offer related classes (e.g. StoreProductDiscount) as well... But that would complicate things a lot, and I think just hiding the entry methods should be ok
Contributor
Yeah we're minimizing complexity by only hiding things at the top level. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This will remove the
promotionaOfferpurchase methods from the API in the custom entitlement computation package