CustomerInfo: support parsing schema version 2 to restore SDK v3.x compatibility#2213
Merged
Conversation
Fies [TRIAGE-240]. When we converted `CustomerInfo` to use `Codable` (#1496), the schema version was also changed from 2 to 3. I don't remember if this was done on purpose, but turns out that it was not necessary. This means that a user opening an app while offline, after upgrading from version `3.x` to `4.x` (>= `4.3`), they would not have a cached `CustomerInfo` and therefore no entitlements. This fixes that by restoring support and adding a specific test with a sample version 2 JSON (which is virtually identical).
aboedo
approved these changes
Jan 17, 2023
aboedo
left a comment
Member
There was a problem hiding this comment.
If this is also the case for Android, could you fix it there as well?
NachoSoto
pushed a commit
that referenced
this pull request
Jan 17, 2023
**This is an automatic release.** ### New Features * Added new `ReceiptParser.fetchAndParseLocalReceipt` (#2204) via NachoSoto (@NachoSoto) * `PurchasesReceiptParser`: added API to parse receipts from `base64` string (#2200) via NachoSoto (@NachoSoto) ### Bugfixes * `CustomerInfo`: support parsing schema version 2 to restore SDK `v3.x` compatibility (#2213) via NachoSoto (@NachoSoto) ### Other Changes * `JSONDecoder`: added decoding type when logging `DecodingError.keyNotFound` (#2212) via NachoSoto (@NachoSoto) * Added `ReceiptParserTests` (#2203) via NachoSoto (@NachoSoto) * Deploy `PurchaseTester` for `macOS` (#2011) via NachoSoto (@NachoSoto) * `ReceiptFetcher`: refactored implementation to log error when failing to fetch receipt (#2202) via NachoSoto (@NachoSoto) * `PostReceiptDataOperation`: replaced receipt `base64` with `hash` for cache key (#2199) via NachoSoto (@NachoSoto) * `PurchaseTester`: small refactor to simplify `Date` formatting (#2210) via NachoSoto (@NachoSoto) * `PurchasesReceiptParser`: improved documentation to reference `default` (#2197) via NachoSoto (@NachoSoto) * Created `CachingTrialOrIntroPriceEligibilityChecker` (#2007) via NachoSoto (@NachoSoto) * Update Gemfile.lock (#2205) via Cesar de la Vega (@vegaro) * remove stalebot in favor of SLAs in Zendesk (#2196) via Andy Boedo (@aboedo) * Update fastlane-plugin-revenuecat_internal to latest version (#2194) via Cesar de la Vega (@vegaro)
Contributor
Author
|
@aboedo Android has a schema version of 3, but looks like it's been that since 2020, so I'm guessing the last time it changed was deliberate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes TRIAGE-240.
When we converted
CustomerInfoto useCodable(#1496), the schema version was also changed from 2 to 3.I don't remember if this was done on purpose, but turns out that it was not necessary.
This means that a user opening an app while offline, after upgrading from version
3.xto4.x(>=4.3), would not have a cachedCustomerInfoand therefore no entitlements.This fixes that by restoring support and adding a specific test with a sample version 2 JSON (which is virtually identical).