Skip to content

Deploy PurchaseTester for macOS#2011

Merged
NachoSoto merged 12 commits into
mainfrom
purchase-tester-testflight-catalyst
Jan 17, 2023
Merged

Deploy PurchaseTester for macOS#2011
NachoSoto merged 12 commits into
mainfrom
purchase-tester-testflight-catalyst

Conversation

@NachoSoto

@NachoSoto NachoSoto commented Oct 28, 2022

Copy link
Copy Markdown
Contributor

Follow up to #2003. Also submitting macOS build for CSDK-510.

Changed this from Catalyst to native macOS because of this issue: fastlane/fastlane#20826

App_store_512

@NachoSoto NachoSoto added the ci label Oct 28, 2022
@NachoSoto NachoSoto force-pushed the purchase-tester-testflight-catalyst branch from c0793eb to 5ec36b7 Compare October 28, 2022 21:32
@NachoSoto NachoSoto marked this pull request as draft October 28, 2022 21:41
@NachoSoto NachoSoto force-pushed the purchase-tester-testflight-catalyst branch 3 times, most recently from 9032c88 to dc44ef9 Compare October 30, 2022 00:58
@NachoSoto NachoSoto force-pushed the purchase-tester-testflight branch from 2eb7f27 to d06d403 Compare November 3, 2022 21:47
Base automatically changed from purchase-tester-testflight to main November 3, 2022 21:48
@NachoSoto NachoSoto force-pushed the purchase-tester-testflight-catalyst branch 5 times, most recently from 20920b0 to a736733 Compare November 4, 2022 17:49
NachoSoto added a commit that referenced this pull request Nov 4, 2022
…th `SPM`

This is required for #2011.

Catalyst is not building reliable with the embedded framework, and Xcode does not allow adding the explicit target dependency.
This solves that.
@NachoSoto NachoSoto force-pushed the purchase-tester-testflight-catalyst branch from a736733 to c52f988 Compare November 4, 2022 19:20
@NachoSoto NachoSoto changed the base branch from main to purchases-tester-swiftui-spm November 4, 2022 19:21
@NachoSoto NachoSoto force-pushed the purchase-tester-testflight-catalyst branch 3 times, most recently from ea4827a to 28f625c Compare November 4, 2022 23:54
@NachoSoto

Copy link
Copy Markdown
Contributor Author

This is pretty much ready, but it's blocked by fastlane/fastlane#20826.

Base automatically changed from purchases-tester-swiftui-spm to main November 8, 2022 12:37
@NachoSoto NachoSoto changed the title [WIP] PurchaseTester for Catalyst [WIP] Purchase Tester for Catalyst Dec 20, 2022
@NachoSoto

Copy link
Copy Markdown
Contributor Author

I'm thinking of resuscitating this and submitting a native macOS build instead (thanks to #2175).

@NachoSoto NachoSoto force-pushed the purchase-tester-testflight-catalyst branch from 28f625c to 9388fa5 Compare January 13, 2023 19:11
@NachoSoto NachoSoto changed the title [WIP] Purchase Tester for Catalyst [WIP] Purchase Tester for macOS Jan 13, 2023
@NachoSoto NachoSoto changed the title [WIP] Purchase Tester for macOS [WIP] Purchase Tester for macOS Jan 13, 2023
@NachoSoto NachoSoto force-pushed the purchase-tester-testflight-catalyst branch from 0537137 to a3b0540 Compare January 13, 2023 20:03
@NachoSoto NachoSoto force-pushed the purchase-tester-testflight-catalyst branch from a3b0540 to d7e8094 Compare January 13, 2023 22:54

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These crashes:

Termination Reason: Namespace DYLD, Code 1 Library missing
Library not loaded: @rpath/RevenueCat_76EF69325FE509FC_PackageProduct.framework/Versions/A/RevenueCat_76EF69325FE509FC_PackageProduct
Referenced from: /Applications/PurchaseTester.app/Contents/MacOS/PurchaseTester
Reason: tried: '/Applications/PurchaseTester.app/Contents/MacOS/Frameworks/RevenueCat_76EF69325FE509FC_PackageProduct.framework/Versions/A/RevenueCat_76EF69325FE509FC_PackageProduct' (no such file), '/Applications/PurchaseTester.app/Contents/MacOS/Frameworks/RevenueCat_76EF69325FE509FC_PackageProduct.framework/Versions/A/RevenueCat_76EF69325FE509FC_PackageProduct' (no such file), '/System/Volumes/Preboot/Cryptexes/OS@rpath/RevenueCat_76EF69325FE509FC_PackageProduct.framework/Versions/A/RevenueCat_76EF69325FE509FC_PackageProduct' (no such file), '/Applications/PurchaseTester.app/Contents/MacOS/Frameworks/RevenueCat_76EF69325FE509FC_PackageProduct.framework/Versions/A/RevenueCat_76EF69325FE509FC_PackageProduct' (no such file), '/Applications/PurchaseTester.a

Were due to this being wrong. macOS has a slightly different folder structure.
@aboedo this was the solution.

@NachoSoto NachoSoto force-pushed the purchase-tester-testflight-catalyst branch 3 times, most recently from b2626ee to 5ef62e1 Compare January 13, 2023 23:19
@NachoSoto NachoSoto changed the title [WIP] Purchase Tester for macOS Purchase Tester for macOS Jan 13, 2023
@NachoSoto NachoSoto removed the WIP label Jan 13, 2023
@NachoSoto NachoSoto marked this pull request as ready for review January 13, 2023 23:20
@NachoSoto

NachoSoto commented Jan 13, 2023

Copy link
Copy Markdown
Contributor Author

This is ready 🎉 /cc @RevenueCat/coresdk

@NachoSoto NachoSoto changed the title Purchase Tester for macOS PurchaseTester for macOS Jan 14, 2023
@NachoSoto NachoSoto changed the title PurchaseTester for macOS Deploy PurchaseTester for macOS Jan 14, 2023

@tonidero tonidero left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread fastlane/Fastfile Outdated
run_precheck_before_submit: false
)

# macOS

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we separate into 2 functions?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good 👍🏻

@NachoSoto NachoSoto force-pushed the purchase-tester-testflight-catalyst branch from 5ef62e1 to 511c63f Compare January 16, 2023 18:07
@NachoSoto NachoSoto enabled auto-merge (squash) January 16, 2023 18:07
@NachoSoto NachoSoto merged commit 81d7808 into main Jan 17, 2023
@NachoSoto NachoSoto deleted the purchase-tester-testflight-catalyst branch January 17, 2023 02:59
NachoSoto pushed a commit that referenced this pull request Jan 17, 2023
**This is an automatic release.**

### New Features
* Added new `ReceiptParser.fetchAndParseLocalReceipt` (#2204) via
NachoSoto (@NachoSoto)
* `PurchasesReceiptParser`: added API to parse receipts from `base64`
string (#2200) via NachoSoto (@NachoSoto)
### Bugfixes
* `CustomerInfo`: support parsing schema version 2 to restore SDK `v3.x`
compatibility (#2213) via NachoSoto (@NachoSoto)
### Other Changes
* `JSONDecoder`: added decoding type when logging
`DecodingError.keyNotFound` (#2212) via NachoSoto (@NachoSoto)
* Added `ReceiptParserTests` (#2203) via NachoSoto (@NachoSoto)
* Deploy `PurchaseTester` for `macOS` (#2011) via NachoSoto (@NachoSoto)
* `ReceiptFetcher`: refactored implementation to log error when failing
to fetch receipt (#2202) via NachoSoto (@NachoSoto)
* `PostReceiptDataOperation`: replaced receipt `base64` with `hash` for
cache key (#2199) via NachoSoto (@NachoSoto)
* `PurchaseTester`: small refactor to simplify `Date` formatting (#2210)
via NachoSoto (@NachoSoto)
* `PurchasesReceiptParser`: improved documentation to reference
`default` (#2197) via NachoSoto (@NachoSoto)
* Created `CachingTrialOrIntroPriceEligibilityChecker` (#2007) via
NachoSoto (@NachoSoto)
* Update Gemfile.lock (#2205) via Cesar de la Vega (@vegaro)
* remove stalebot in favor of SLAs in Zendesk (#2196) via Andy Boedo
(@aboedo)
* Update fastlane-plugin-revenuecat_internal to latest version (#2194)
via Cesar de la Vega (@vegaro)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants