Fixed Xcode 13.2.x / Swift 5.5 compatibility#1994
Merged
Merged
Conversation
aboedo
approved these changes
Oct 24, 2022
aboedo
reviewed
Oct 24, 2022
1032c14 to
9bc4d8c
Compare
9bc4d8c to
8a0efd4
Compare
NachoSoto
commented
Oct 24, 2022
|
|
||
| } | ||
|
|
||
| extension CustomerAPI: Sendable {} |
Contributor
Author
There was a problem hiding this comment.
This was unnecessary and fixed a lot of unnecessary warnings.
aboedo
approved these changes
Oct 24, 2022
This was referenced Oct 24, 2022
NachoSoto
pushed a commit
that referenced
this pull request
Oct 26, 2022
**This is an automatic release.** ### Bugfixes * Fixed Xcode 13.2.x / Swift 5.5 compatibility (#1994) via NachoSoto (@NachoSoto) ### Other Changes * Update `fastlane` (#1998) via NachoSoto (@NachoSoto) * Documentation: fixed missing docs from inherited symbols (#1997) via NachoSoto (@NachoSoto) * CI: added job to test compilation with `Xcode 13.2.1` / `Swift 5.5` (#1990) via NachoSoto (@NachoSoto) * Extracted `TrialOrIntroPriceEligibilityCheckerType` (#1983) via NachoSoto (@NachoSoto) * CI: removed redundant `swiftlint` installation (#1993) via NachoSoto (@NachoSoto) * `Nimble`: use a fixed version (#1991) via NachoSoto (@NachoSoto) * Update fastlane-plugin-revenuecat_internal (#1989) via Cesar de la Vega (@vegaro) * `Purchases.logIn`: log warning if attempting to use a static `appUserID` (#1958) via NachoSoto (@NachoSoto) * Created `InternalAPI` for "health" request (#1971) via NachoSoto (@NachoSoto) Co-authored-by: RCGitBot <dev+RCGitBot@revenuecat.com>
NachoSoto
added a commit
that referenced
this pull request
Feb 17, 2023
Fixes #2291. This has led to issues in the past too (#1994, #2221, RevenueCat/purchases-flutter#516, RevenueCat/purchases-flutter#507) because I tried to reuse that code to call a single completion method. The new version of Swift makes that impossible now, because it detects that `@MainActor` isn't available in iOS 12. To finally work around all those issues, this simply duplicates this single line of code, which should work across all versions of Swift.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SDKONCALL-156.
This will be covered by #1990.