CI: added job to test compilation with Xcode 13.2.1 / Swift 5.5#1990
Merged
Conversation
Merged
27896ef to
96ef980
Compare
4245bb4 to
7b47b8c
Compare
d87bb48 to
a51eb80
Compare
7107ed5 to
9ef452e
Compare
Contributor
Author
|
FYI I'm going to make this only run on |
9bc4d8c to
8a0efd4
Compare
58c6868 to
bd028ed
Compare
Contributor
Author
|
This passed, but I'm going to reference |
NachoSoto
commented
Oct 25, 2022
Contributor
Author
There was a problem hiding this comment.
TODO: replace with pod lib lint instead
Contributor
Author
There was a problem hiding this comment.
I wrote this last night, I'm doing it now hehe
Contributor
Author
There was a problem hiding this comment.
Going back to swift build because pod lib lint fails with the old Xcode:
Undefined symbols for architecture arm64:
"_swift_getFunctionTypeMetadataGlobalActorBackDeploy", referenced from:
type metadata accessor for @Swift.MainActor @sendable (RevenueCat.StoreTransaction?, RevenueCat.CustomerInfo?, __C.NSError?, Swift.Bool) -> () in CustomerInfo.o
type metadata accessor for @Swift.MainActor @sendable () -> () in Deprecations.o
ld: symbol(s) not found for architecture arm64
[SDKONCALL-156].
To support Xcode 13.2
Xcode 13.2.1 / Swift 5.5
c92fe7b to
75bc59c
Compare
NachoSoto
added a commit
to RevenueCat/purchases-hybrid-common
that referenced
this pull request
Oct 25, 2022
557d79b to
c5985d8
Compare
NachoSoto
added a commit
to RevenueCat/purchases-hybrid-common
that referenced
this pull request
Oct 25, 2022
c5985d8 to
2e99be3
Compare
NachoSoto
pushed a commit
that referenced
this pull request
Oct 26, 2022
**This is an automatic release.** ### Bugfixes * Fixed Xcode 13.2.x / Swift 5.5 compatibility (#1994) via NachoSoto (@NachoSoto) ### Other Changes * Update `fastlane` (#1998) via NachoSoto (@NachoSoto) * Documentation: fixed missing docs from inherited symbols (#1997) via NachoSoto (@NachoSoto) * CI: added job to test compilation with `Xcode 13.2.1` / `Swift 5.5` (#1990) via NachoSoto (@NachoSoto) * Extracted `TrialOrIntroPriceEligibilityCheckerType` (#1983) via NachoSoto (@NachoSoto) * CI: removed redundant `swiftlint` installation (#1993) via NachoSoto (@NachoSoto) * `Nimble`: use a fixed version (#1991) via NachoSoto (@NachoSoto) * Update fastlane-plugin-revenuecat_internal (#1989) via Cesar de la Vega (@vegaro) * `Purchases.logIn`: log warning if attempting to use a static `appUserID` (#1958) via NachoSoto (@NachoSoto) * Created `InternalAPI` for "health" request (#1971) via NachoSoto (@NachoSoto) Co-authored-by: RCGitBot <dev+RCGitBot@revenuecat.com>
NachoSoto
added a commit
that referenced
this pull request
Oct 26, 2022
It contains the updated `macOS` SDK so we should be able to use it for most jobs. #1990 will ensure that we maintain backwards compatibility with the oldest Xcode version we support. I disabled `watchOS` from `check_pods` until CocoaPods/CocoaPods#11558 is fixed.
NachoSoto
added a commit
to RevenueCat/purchases-hybrid-common
that referenced
this pull request
Nov 3, 2022
aboedo
pushed a commit
to RevenueCat/purchases-hybrid-common
that referenced
this pull request
Nov 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To cover SDKONCALL-156.