Skip to content

SnapshotTesting: require version 1.9.0 to keep supporting iOS 12/13 tests#1931

Merged
NachoSoto merged 1 commit into
mainfrom
snapshot-testing-dependency
Sep 22, 2022
Merged

SnapshotTesting: require version 1.9.0 to keep supporting iOS 12/13 tests#1931
NachoSoto merged 1 commit into
mainfrom
snapshot-testing-dependency

Conversation

@NachoSoto

Copy link
Copy Markdown
Contributor

The new 1.10.0 version requires iOS 13+, which is making CI builds all fail.

We'll be able to upgrade when we drop support for those version, but for now we're stuck with 1.9.0

…12/13 tests

[The new 1.10.0 version](https://github.com/pointfreeco/swift-snapshot-testing/releases/tag/1.10.0) requires iOS 13+, which is making CI builds all fail.

We'll be able to upgrade when we drop support for those version, but for now we're stuck with `1.9.0`
@NachoSoto NachoSoto added pr:dependencies Changes on external dependencies test labels Sep 22, 2022
@NachoSoto NachoSoto requested a review from a team September 22, 2022 22:30
@NachoSoto NachoSoto changed the title SwiftSnapshotTesting: require version 1.9.0 to keep supporting iOS 12/13 tests SnapshotTesting: require version 1.9.0 to keep supporting iOS 12/13 tests Sep 22, 2022

@joshdholtz joshdholtz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@NachoSoto NachoSoto merged commit 30b9670 into main Sep 22, 2022
@NachoSoto NachoSoto deleted the snapshot-testing-dependency branch September 22, 2022 23:03
NachoSoto added a commit that referenced this pull request Sep 23, 2022
… tests (#1931)

[The new 1.10.0
version](https://github.com/pointfreeco/swift-snapshot-testing/releases/tag/1.10.0)
requires iOS 13+, which is making CI builds all fail.

We'll be able to upgrade when we drop support for those version, but for
now we're stuck with `1.9.0`
NachoSoto pushed a commit that referenced this pull request Sep 23, 2022
**This is an automatic release.**

### Bugfixes
* `Purchases.beginRefundRequest`: ensured errors are `PublicError`
(#1913) via NachoSoto (@NachoSoto)
* `PurchaseTesterSwiftUI`: fixed macOS target (#1915) via NachoSoto
(@NachoSoto)
### Other Changes
* `SnapshotTesting`: require version 1.9.0 to keep supporting iOS 12/13
tests (#1931) via NachoSoto (@NachoSoto)
* Fixed `tvOS` tests (#1928) via NachoSoto (@NachoSoto)
* `pre-commit` hook: also verify leftover API keys in `PurchaseTester`
(#1914) via NachoSoto (@NachoSoto)
* `CircleCI`: changed iOS 12/13 to use Xcode 13 (#1918) via NachoSoto
(@NachoSoto)
* `PurchaseTesterSwiftUI`: removed unnecessary `UIApplicationDelegate`
(#1916) via NachoSoto (@NachoSoto)
* `CircleCI`: changed all jobs to use Xcode 14 (#1909) via NachoSoto
(@NachoSoto)
* `Atomic`: added unit test to verify `value`'s setter (#1905) via
NachoSoto (@NachoSoto)
* `spm build` CI job: changed to release build (#1903) via NachoSoto
(@NachoSoto)
* `StoreKitUnitTests`: compile on iOS 11.0+ (#1904) via NachoSoto
(@NachoSoto)
* `Purchases`: only expose testing data on `DEBUG` (#1902) via NachoSoto
(@NachoSoto)
* `Integration Tests`: added test to verify re-subscription behavior
(#1898) via NachoSoto (@NachoSoto)
* `IntegrationTests`: simplified `testExpireSubscription` to fix flaky
test (#1899) via NachoSoto (@NachoSoto)
* `Integration Tests`: actually verify that entitlement is active
(#1880) via NachoSoto (@NachoSoto)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:dependencies Changes on external dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants