[AUTOMATIC] Release/4.12.1#1923
Merged
Merged
Conversation
Contributor
|
Updating the header failed: https://app.circleci.com/pipelines/github/RevenueCat/purchases-ios/8160/workflows/c7a36695-1b99-4b15-bc75-a45acbeb300e/jobs/37697 |
Contributor
|
Failures fixed by #1927. |
Contributor
Turns out we hadn't been running tests on `tvOS` for a while: > [19:08:22]: Couldn't find any matching simulators for '["Apple TV (15.2)"]' - falling back to default simulator > [19:08:22]: Found simulator "iPhone 13 Pro (15.5)" I found this went I went to dig into [this failure](#1926 (comment)). Turns out that wasn't running on `tvOS` anyway. This turns them back on, fixes the compilation issues on `tvOS` tests, and ensures that we don't run into this issue again. ### Changes: - Renamed device in lane `test_tvos` - Enabled `ensure_devices_found` on `iOS` and `tvOS` lanes. This will also ensure that we don't stop running tests on iOS XX because it doesn't find that simulator. - Removed `UnitTestHostApp` storyboards and scene, since those aren't supported in `tvOS`, and aren't needed because there's no UI. - Made `StoreKitUnitTests` and `UnitTestHostApp` targets universal - No longer linking `AdServices` on `tvOS` in test targets - Disabled attribution tests on `tvOS`. Those methods weren't being compiled, but we were testing that a message was being sent, even though it no longer was. - Changed iOS 14 tests to use Xcode 13 due to xcpretty/xcode-install#466 (same as #1918).
… tests (#1931) [The new 1.10.0 version](https://github.com/pointfreeco/swift-snapshot-testing/releases/tag/1.10.0) requires iOS 13+, which is making CI builds all fail. We'll be able to upgrade when we drop support for those version, but for now we're stuck with `1.9.0`
NachoSoto
approved these changes
Sep 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic release.
Bugfixes
Purchases.beginRefundRequest: ensured errors arePublicError(Purchases.beginRefundRequest: ensured errors arePublicError#1913) via NachoSoto (@NachoSoto)PurchaseTesterSwiftUI: fixed macOS target (PurchaseTesterSwiftUI: fixed macOS target #1915) via NachoSoto (@NachoSoto)Other Changes
SnapshotTesting: require version 1.9.0 to keep supporting iOS 12/13 tests (SnapshotTesting: require version 1.9.0 to keep supporting iOS 12/13 tests #1931) via NachoSoto (@NachoSoto)tvOStests (FixedtvOStests #1928) via NachoSoto (@NachoSoto)pre-commithook: also verify leftover API keys inPurchaseTester(pre-commithook: also verify leftover API keys inPurchaseTester#1914) via NachoSoto (@NachoSoto)CircleCI: changed iOS 12/13 to use Xcode 13 (CircleCI: changed iOS 12/13 to use Xcode 13 #1918) via NachoSoto (@NachoSoto)PurchaseTesterSwiftUI: removed unnecessaryUIApplicationDelegate(PurchaseTesterSwiftUI: removed unnecessaryUIApplicationDelegate#1916) via NachoSoto (@NachoSoto)CircleCI: changed all jobs to use Xcode 14 (CircleCI: changed all jobs to use Xcode 14 #1909) via NachoSoto (@NachoSoto)Atomic: added unit test to verifyvalue's setter (Atomic: added unit test to verifyvalue's setter #1905) via NachoSoto (@NachoSoto)spm buildCI job: changed to release build (spm buildCI job: changed to release build #1903) via NachoSoto (@NachoSoto)StoreKitUnitTests: compile on iOS 11.0+ (StoreKitUnitTests: compile on iOS 11.0+ #1904) via NachoSoto (@NachoSoto)Purchases: only expose testing data onDEBUG(Purchases: only expose testing data onDEBUG#1902) via NachoSoto (@NachoSoto)Integration Tests: added test to verify re-subscription behavior (Integration Tests: added test to verify re-subscription behavior #1898) via NachoSoto (@NachoSoto)IntegrationTests: simplifiedtestExpireSubscriptionto fix flaky test (IntegrationTests: simplifiedtestExpireSubscriptionto fix flaky test #1899) via NachoSoto (@NachoSoto)Integration Tests: actually verify that entitlement is active (Integration Tests: actually verify that entitlement is active #1880) via NachoSoto (@NachoSoto)