[AUTOMATIC] Release/4.12.0#1890
Merged
Merged
Conversation
NachoSoto
approved these changes
Sep 7, 2022
Contributor
|
Looks like Carthage tests are crashing the simulator for some reason (ran them 3 times). |
Contributor
|
I got Carthage tests passing locally with no issues... but I did fix a warning by removing the unnecessary |
d5a93a4 to
a54c2d9
Compare
8e01228 to
b727007
Compare
NachoSoto
added a commit
that referenced
this pull request
Sep 8, 2022
For #1890. The failure was likely because the simulators had a dialog which was blocking the tests from continuing. In order to fix that, I removed the test host from the target, which was never necessary and will make running these tests a bit faster. ### Changes: - `CarthageInstallation`: removed unnecessary `FRAMEWORK_SEARCH_PATHS` - Removed test host - Added single scheme with `test` action
b727007 to
d360bff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic release.
Bugfixes
watchOS: fixed crash when ran on single-target apps with Xcode 14 and beforewatchOS 9.0(watchOS: fixed crash when ran on single-target apps with Xcode 14 and before watchOS 9.0 #1895) via NachoSoto (@NachoSoto)CustomerInfoManager/OfferingsManager: improved display of underlying errors (CustomerInfoManager/OfferingsManager: improved display of underlying errors #1888) via NachoSoto (@NachoSoto)Offering: improved confusing log forPackageType.custom(Offering: improved confusing log forPackageType.custom#1884) via NachoSoto (@NachoSoto)PurchasesOrchestrator: don't log warning ifallowSharingAppStoreAccountsetting was never explicitly set (PurchasesOrchestrator: don't log warning ifallowSharingAppStoreAccountsetting was never explicitly set #1885) via NachoSoto (@NachoSoto)PurchasesErrorand fixed some incorrect returned error types (Introduced type-safePurchasesErrorand fixed some incorrect returned error types #1879) via NachoSoto (@NachoSoto)CustomerInfoManager: fixed thread-unsafe implementation (CustomerInfoManager: fixed thread-unsafe implementation #1878) via NachoSoto (@NachoSoto)New Features
StoreKitWrapperif SK2 is enabled and available (Disable SK1'sStoreKitWrapperif SK2 is enabled and available #1882) via NachoSoto (@NachoSoto)Sendablesupport (Sendablesupport #1795) via NachoSoto (@NachoSoto)Other Changes
StoreKitWrappertoStoreKit1Wrapper(RenamedStoreKitWrappertoStoreKit1Wrapper#1886) via NachoSoto (@NachoSoto)DEAD_CODE_STRIPPING(EnabledDEAD_CODE_STRIPPING#1887) via NachoSoto (@NachoSoto)HTTPClient: addedX-Client-Bundle-IDand logged on SDK initialization (HTTPClient: addedX-Client-Bundle-IDand logged on SDK initialization #1883) via NachoSoto (@NachoSoto)StoreKit2Setting.shouldOnlyUseStoreKit2(AddedStoreKit2Setting.shouldOnlyUseStoreKit2#1881) via NachoSoto (@NachoSoto)TestLogHandlerto simplify how we test logged messages (IntroducedTestLogHandlerto simplify how we test logged messages #1858) via NachoSoto (@NachoSoto)Integration Tests: added test for purchasingStoreProductinstead ofPackage(Integration Tests: added test for purchasingStoreProductinstead ofPackage#1875) via NachoSoto (@NachoSoto)ErrorUtils: added test to verify that returned errors can be converted toErrorCode(ErrorUtils: added test to verify that returned errors can be converted toErrorCode#1871) via NachoSoto (@NachoSoto)