Fixed CarthageInstallation tests#1896
Merged
Merged
Conversation
aboedo
approved these changes
Sep 8, 2022
aboedo
left a comment
Member
There was a problem hiding this comment.
🚢 assuming these still break if we break carthage
Contributor
Author
|
Yeah this change has nothing to do with Carthage, just simplifying the test target. It's still building and linking the Carthage framework in the same way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1890.
The failure was likely because the simulators had a dialog which was blocking the tests from continuing. In order to fix that, I removed the test host from the target, which was never necessary and will make running these tests a bit faster.
Changes:
CarthageInstallation: removed unnecessaryFRAMEWORK_SEARCH_PATHStestaction