Skip to content

Release/4.10.0#1800

Merged
joshdholtz merged 5 commits into
mainfrom
release/4.10.0
Aug 8, 2022
Merged

Release/4.10.0#1800
joshdholtz merged 5 commits into
mainfrom
release/4.10.0

Conversation

@joshdholtz

@joshdholtz joshdholtz commented Aug 8, 2022

Copy link
Copy Markdown
Member

New Features

Bugfixes

Other Changes

@RevenueCat-Danger-Bot

Copy link
Copy Markdown
1 Error
🚫 Label the PR using one of the change type labels: ["breaking", "build", "ci", "docs", "feat", "fix", "perf", "refactor", "style", "test"]

Generated by 🚫 Danger

@joshdholtz

Copy link
Copy Markdown
Member Author

replace_in no longer exists but is being used in Fastfile 😱 Going to add a commit to fix

@taquitos taquitos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update changelog 😄

Comment thread CHANGELOG.md Outdated
@@ -1,3 +1,15 @@
## 4.10.0
## Bugfixes

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a section from the .latest.md

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tonidero @vegaro I think there needs to be a change to the fastlane plugin to make these sections in CHANGELOG.md use ### instead of ## (like in CHANGELOG.latest.md

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting! I can fix tomorrow morning

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taquitos taquitos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🐐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants