Skip to content

Support for new fastlane internal plugin for automation#1779

Merged
tonidero merged 10 commits into
mainfrom
support-fastlane-revenuecat-internal-plugin
Aug 4, 2022
Merged

Support for new fastlane internal plugin for automation#1779
tonidero merged 10 commits into
mainfrom
support-fastlane-revenuecat-internal-plugin

Conversation

@tonidero

@tonidero tonidero commented Jul 28, 2022

Copy link
Copy Markdown
Contributor

Description

This PR adds support for the new fastlane revenuecat internal plugin . Currently it will use the plugin for the bump, github_release and prepare_next_version lanes. Much of the logic has already been moved to the plugin

TODO

Once plugin PRs have been merged:

@NachoSoto NachoSoto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So clean 👏🏻

Comment thread fastlane/CommonFastfile Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Comment thread fastlane/Fastfile Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For those wondering like me, this is defined inline now since it's only used in one place 👍🏻

@tonidero tonidero force-pushed the support-fastlane-revenuecat-internal-plugin branch from f183d7e to dab692e Compare August 1, 2022 11:15
@tonidero

This comment was marked as outdated.

@tonidero tonidero marked this pull request as ready for review August 1, 2022 12:37
@tonidero tonidero requested a review from a team August 1, 2022 12:37
@tonidero

tonidero commented Aug 3, 2022

Copy link
Copy Markdown
Contributor Author

This is now final @RevenueCat/sdk

@aboedo aboedo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

Comment thread fastlane/CommonFastfile Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@tonidero tonidero merged commit ea4bab3 into main Aug 4, 2022
@tonidero tonidero deleted the support-fastlane-revenuecat-internal-plugin branch August 4, 2022 09:26
@vegaro vegaro added the ci label Aug 5, 2022
This was referenced Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants