Invalidates gem caches and separates danger and macOS caches#1798
Merged
Conversation
tonidero
approved these changes
Aug 8, 2022
tonidero
left a comment
Contributor
There was a problem hiding this comment.
LGTM! I see you're rerunning the jobs and they are using the cache much faster now 🎉
| - run: bundle install --clean --path vendor/bundle | ||
| - save_cache: | ||
| key: v1-gem-cache-{{ checksum "Gemfile.lock" }} | ||
| key: v2-gem-cache-{{ checksum "Gemfile.lock" }} |
Contributor
There was a problem hiding this comment.
Hmm I wonder why we don't call install_dependencies here instead... But it's not related to this change, so we can look into it later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.circleci.com/pipelines/github/RevenueCat/purchases-ios/7590/workflows/f9b051cd-6b41-4d7b-b4b1-77edbec943a5
Restoring caches is taking long time because it's failing to restore caches that are stored in Danger's job, which runs on a Docker image. In a run from before the merge of the Danger changes, it’s finding the cache in Cached paths:
/Users/distiller/purchases-ios/vendor/bundle. In the newer runs it’s failing in/home/circleci/purchases-ios/vendor/bundle/CircleCI docs say:
So it looks like the issue is with the paths. I think the best solution is to have two different caches, one for Danger and one for the MacOS executors