Logger: wrap message in @autoclosure to avoid creating when LogLevel is disabled#1781
Merged
Conversation
…gLevel` is disabled I realized in #1780 that we might be doing unnecessary work creating messages that are never logged. This is a small optimization to prevent that.
Merged
NachoSoto
added a commit
that referenced
this pull request
Aug 1, 2022
### Fixes: * `CustomerInfoResponseHandler`: return `CustomerInfo` instead of error if the response was successful (#1778) via NachoSoto (@NachoSoto) * Error logging: `logErrorIfNeeded` no longer prints message if it's the same as the error description (#1776) via NachoSoto (@NachoSoto) * fix another broken link in docC docs (#1777) via aboedo (@aboedo) * fix links to restorePurchase (#1775) via aboedo (@aboedo) * fix getProducts docs broken link (#1772) via aboedo (@aboedo) ### Improvements: * `Logger`: wrap `message` in `@autoclosure` to avoid creating when `LogLevel` is disabled (#1781) via NachoSoto (@NachoSoto) ### Other changes: * Lint: fixed `SubscriberAttributesManager` (#1774) via NachoSoto (@NachoSoto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized in #1780 that we might be doing unnecessary work creating messages that are never logged. This is a small optimization to prevent that.