Skip to content

fix another broken link in docC docs#1777

Merged
aboedo merged 1 commit into
mainfrom
fix/link_to_get_offerings
Jul 27, 2022
Merged

fix another broken link in docC docs#1777
aboedo merged 1 commit into
mainfrom
fix/link_to_get_offerings

Conversation

@aboedo

@aboedo aboedo commented Jul 27, 2022

Copy link
Copy Markdown
Member

Fix another broken link. Again, not sure why we're not getting a warning

@aboedo aboedo requested a review from a team July 27, 2022 19:48
@aboedo aboedo self-assigned this Jul 27, 2022

@NachoSoto NachoSoto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this not work only when CMD+clicking in Xcode or is it broken in the generated docs too?

@aboedo

aboedo commented Jul 27, 2022

Copy link
Copy Markdown
Member Author

it looks like it works correctly in the generated docs, just not on cmd click

@aboedo

aboedo commented Jul 27, 2022

Copy link
Copy Markdown
Member Author

which does explain why we're not getting a warning

@aboedo aboedo merged commit e0412fd into main Jul 27, 2022
@aboedo aboedo deleted the fix/link_to_get_offerings branch July 27, 2022 20:00
@NachoSoto NachoSoto mentioned this pull request Jul 29, 2022
This was referenced Aug 1, 2022
NachoSoto added a commit that referenced this pull request Aug 1, 2022
### Fixes:
* `CustomerInfoResponseHandler`: return `CustomerInfo` instead of error if the response was successful (#1778) via NachoSoto (@NachoSoto)
* Error logging: `logErrorIfNeeded` no longer prints message if it's the same as the error description (#1776) via NachoSoto (@NachoSoto)
* fix another broken link in docC docs (#1777) via aboedo (@aboedo)
* fix links to restorePurchase (#1775) via aboedo (@aboedo)
* fix getProducts docs broken link (#1772) via aboedo (@aboedo)

### Improvements:
* `Logger`: wrap `message` in `@autoclosure` to avoid creating when `LogLevel` is disabled (#1781) via NachoSoto (@NachoSoto)

### Other changes:
* Lint: fixed `SubscriberAttributesManager` (#1774) via NachoSoto (@NachoSoto)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants