Disabled tests that rely on StoreKitConfigTestCase.changeStorefront on iOS 16.0#1701
Merged
Conversation
This is currently broken on iOS 16.
StoreKitConfigTestCase.changeStorefrontStoreKitConfigTestCase.changeStorefront on iOS 16.0
This is currently broken on iOS 16. I filed [CSDK-261] to make sure we review this before the GM is out.
2bff034 to
194349c
Compare
aboedo
approved these changes
Jun 30, 2022
NachoSoto
added a commit
that referenced
this pull request
Jun 30, 2022
Fixes [CSDK-260]. ### Depends on: - #1698 - #1699 - #1700 - #1701 [CSDK-260]: https://revenuecats.atlassian.net/browse/CSDK-260?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
NachoSoto
added a commit
that referenced
this pull request
Aug 9, 2022
See #1701. Apple fixed this in beta 5!
Contributor
Author
|
Reverted in #1811 |
NachoSoto
added a commit
that referenced
this pull request
Aug 9, 2022
See #1701. Apple fixed this in beta 5!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is currently broken on iOS 16.
I filed CSDK-261 to make sure we review this before the GM is out.
I filed a Radar:
We might have to wait for a future beta, or find a workaround.