Skip to content

CircleCI: added job for iOS 16 tests#1691

Merged
NachoSoto merged 2 commits into
mainfrom
ios-16-tests
Jun 30, 2022
Merged

CircleCI: added job for iOS 16 tests#1691
NachoSoto merged 2 commits into
mainfrom
ios-16-tests

Conversation

@NachoSoto

@NachoSoto NachoSoto commented Jun 10, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

@NachoSoto NachoSoto requested a review from a team June 10, 2022 19:29
@NachoSoto

NachoSoto commented Jun 10, 2022

Copy link
Copy Markdown
Contributor Author

This isn't my issue, is it?

Creating a dedicated VM with xcode:14.0.0 image

Assigned VM request id: 236172730
provisioning: .
We had an unexpected error preparing a VM for this build, potentially due to our infrastructure or cloud provider. Please retry the build in a few minutes

Unexpected environment preparation error: failed to create a vm: VM creation failed

@NachoSoto

NachoSoto commented Jun 10, 2022

Copy link
Copy Markdown
Contributor Author

Re-running

@joshdholtz

joshdholtz commented Jun 13, 2022

Copy link
Copy Markdown
Member

@NachoSoto I re-ran this again this morning and failing on Stored properties cannot be marked potentially unavailable with '@available' which I think we fixed in the public API but seems like we might have an implementation of this in the tests? 🤔

@NachoSoto

NachoSoto commented Jun 14, 2022

Copy link
Copy Markdown
Contributor Author

@joshdholtz haha of course. I'll send a PR fixing that.

@NachoSoto

NachoSoto commented Jun 14, 2022

Copy link
Copy Markdown
Contributor Author

Tests are running now: https://app.circleci.com/pipelines/github/RevenueCat/purchases-ios/7187/workflows/9a5ae035-69ee-4ee7-ba2b-19c617651d3a/jobs/29405

Pending #1701 now.

@NachoSoto NachoSoto force-pushed the ios-16-tests branch 2 times, most recently from 8b3858f to fe49d2b Compare June 16, 2022 21:49
@NachoSoto NachoSoto removed the blocked label Jun 23, 2022
@NachoSoto NachoSoto merged commit 0905f85 into main Jun 30, 2022
@NachoSoto NachoSoto deleted the ios-16-tests branch June 30, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aboedo aboedo aboedo approved these changes

Assignees

No one assigned

Labels

iOS 16

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NachoSoto @joshdholtz @aboedo