Fixed ROT13.string thread-safety#1686
Merged
Merged
Conversation
Fixes #1685. ### Description Swift's `lazy` and `static` property initialization is always thread-safe. However, `key` was only created as an empty dictionary, and the evaluation of `ROT13.string`, which was the one initializing that data, wasn't isolated. By creating `ROT13.key` inline, this ensures that the initialization is only done once in a thread-safe way.
Merged
NachoSoto
added a commit
that referenced
this pull request
Jun 10, 2022
_This release is compatible with Xcode 14 beta 1_ ### Bug fixes * `EntitlementInfo.isActive` returns true if `requestDate == expirationDate` (#1684) via beylmk (@beylmk) * Fixed usages of `seealso` (#1689) via NachoSoto (@NachoSoto) * Fixed `ROT13.string` thread-safety (#1686) via NachoSoto (@NachoSoto) * `PurchasesOrchestrator`: replaced calls to `syncPurchases` with posting receipt for an individual product during SK2 purchases (#1666) via NachoSoto (@NachoSoto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1685.
Description
Swift's
lazyandstaticproperty initialization is always thread-safe. However,keywas only created as an empty dictionary, and the evaluation ofROT13.string, which was the one initializing that data, wasn't isolated.By creating
ROT13.keyinline, this ensures that the initialization is only done once in a thread-safe way.