EntitlementInfo.isActive returns true if requestDate == expirationDate#1684
Merged
Conversation
Contributor
|
I think this is safe. |
NachoSoto
approved these changes
Jun 10, 2022
| } | ||
|
|
||
| func testSubscriptionActiveIfExpiresDateEqualsRequestDate() throws { | ||
| let expirationAndRequestDate = "2019-08-16T10:30:42Z" |
Contributor
|
@aboedo this looks good to you too? |
Member
|
looks good, although you're stealing a second's worth of subscription away from folks 😅 (jk, a second in a subscription in production is nothing) |
Merged
NachoSoto
added a commit
that referenced
this pull request
Jun 10, 2022
_This release is compatible with Xcode 14 beta 1_ ### Bug fixes * `EntitlementInfo.isActive` returns true if `requestDate == expirationDate` (#1684) via beylmk (@beylmk) * Fixed usages of `seealso` (#1689) via NachoSoto (@NachoSoto) * Fixed `ROT13.string` thread-safety (#1686) via NachoSoto (@NachoSoto) * `PurchasesOrchestrator`: replaced calls to `syncPurchases` with posting receipt for an individual product during SK2 purchases (#1666) via NachoSoto (@NachoSoto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Giving the end users back a millisecond of entitlement access, and hopefully solving a Sandbox issue wherein entitlements are returned as inactive because expirationDate == latestPurchaseDate for 30 second subscription renewals.
Did I miss any repercussions around making this change?