Fix for not being able to read receipts on watchOS#1625
Merged
Conversation
aboedo
approved these changes
May 31, 2022
| minorVersion: 0, | ||
| patchVersion: 0) | ||
| let isBelowFirstOSVersionWithoutBug = ProcessInfo.processInfo.isOperatingSystemAtLeast(firstOSVersionWithoutBug) | ||
| let isBelowFirstOSVersionWithoutBug = !ProcessInfo.processInfo.isOperatingSystemAtLeast(firstOSVersionWithoutBug) |
Member
There was a problem hiding this comment.
Great catch!! This was introduced during the Swift migration, it is correct in v3.
Thanks so much for reporting and fixing!! 🎉 👏 🏆
Merging and we'll get it shipped soon!
Member
|
There's a lint issue now because the line goes over 120 chars, but we'll fix it as a separate thing |
Merged
NachoSoto
added a commit
that referenced
this pull request
Jun 2, 2022
Fixes [CSDK-24]. Fix added in #1625.
Merged
NachoSoto
added a commit
that referenced
this pull request
Jun 2, 2022
### New Features * `Purchases.customerInfo()`: added overload with a new `CacheFetchPolicy` (#1608) via NachoSoto (@NachoSoto) * `Storefront`: added `sk1CurrentStorefront` for Objective-C (#1614) via NachoSoto (@NachoSoto) ### Bug Fixes * Fix for not being able to read receipts on watchOS (#1625) via Patrick Busch (@patrickbusch) ### Other Changes * Added tests for `PurchasesOrchestrator` invoking `listenForTransactions` only if SK2 is enabled (#1618) via NachoSoto (@NachoSoto) * `PurchasesOrchestrator`: removed `lazy` hack for properties with `@available` (#1596) via NachoSoto (@NachoSoto) * `PurchasesOrchestrator.purchase(sk2Product:promotionalOffer:)`: simplified implementation with new operator (#1602) via NachoSoto (@NachoSoto)
NachoSoto
added a commit
that referenced
this pull request
Jun 2, 2022
…`StoreKitWorkarounds` (#1640) Fixes [CSDK-24]. Fix added in #1625. [CSDK-24]: https://revenuecats.atlassian.net/browse/CSDK-24?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Member
|
@patrickbusch thanks once more for your help on this one! the fix has been shipped as a part of 4.5.0 🎉 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
purchases-androidand hybridsMotivation
Description