Added tests for ReceiptFetcher.receiptData on watchOS and moved to StoreKitWorkarounds#1640
Conversation
There was a problem hiding this comment.
This test ensures that the logic is only for watchOS.
|
I'll look at the failures tomorrow. |
There was a problem hiding this comment.
[not for this PR] I wonder if it'd make sense to move this one to StoreKitWorkarounds
There was a problem hiding this comment.
Oh yeah! Let me do that
aboedo
left a comment
There was a problem hiding this comment.
good to go after fixing the URL param for watchOSReceiptURL
There was a problem hiding this comment.
pod lib lint caught this:
the receiptURL variable is URL? but watchOSReceiptURL(_:) takes a non-optional URL.
we should update this method to take in an optional URL? or update the callsite to only call it if the receipt URL is not nil.
This wouldn't be caught in Xcode unless you're explicitly building for watchOS targets.
pod lib lint is awesome 🎉
There was a problem hiding this comment.
Smart of me to not compile this watchOS fix on watchOS 🤦🏻
Fixes [CSDK-24]. Fix added in #1625.
eb06b62 to
e3f602d
Compare
|
Does this still look good? |
ReceiptFetcher.receiptData on watchOSReceiptFetcher.receiptData on watchOS and moved to StorekitWorkarounds
ReceiptFetcher.receiptData on watchOS and moved to StorekitWorkaroundsReceiptFetcher.receiptData on watchOS and moved to StoreKitWorkarounds
|
iOS 15 tests fail because they timed out. |
Fixes CSDK-24.
Fix added in #1625.