Enable offline entitlements#987
Merged
Merged
Conversation
250d84f to
a1df7e4
Compare
Member
|
Do we need #959 first? I am going to work on rebasing that PR today |
Contributor
Author
You're right! Holding this PR until that is merged as well |
a1df7e4 to
c6f739b
Compare
Codecov Report
@@ Coverage Diff @@
## main #987 +/- ##
==========================================
+ Coverage 85.35% 85.38% +0.03%
==========================================
Files 168 168
Lines 5997 5989 -8
Branches 837 834 -3
==========================================
- Hits 5119 5114 -5
+ Misses 546 544 -2
+ Partials 332 331 -1
|
NachoSoto
approved these changes
May 16, 2023
c6f739b to
8d526d4
Compare
tonidero
added a commit
that referenced
this pull request
May 23, 2023
### Description Depends on #987 This PR adds some integration tests checking some basic behaviors of offline entitlements. Mostly making sure the mode is turn on and off as expected. <!-- Describe your changes in detail --> <!-- Please describe in detail how you tested your changes -->
This was referenced May 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This removes the flag that was disabling offline entitlements, so we actually start using offline entitlements
TODO