Diagnostics: Sync diagnostics when configuring SDK if needed#791
Conversation
There was a problem hiding this comment.
This will cause a conflict when merging with #782 but we can easily solve it then.
Codecov Report
@@ Coverage Diff @@
## diagnostics #791 +/- ##
==============================================
Coverage ? 81.95%
==============================================
Files ? 127
Lines ? 4200
Branches ? 529
==============================================
Hits ? 3442
Misses ? 548
Partials ? 210 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
If we have it as false, and since this is for our own benefit, will anyone ever enable it?
There was a problem hiding this comment.
We recently decided that we would do better for our customers by leaving it disabled by default. It would certainly cause us to gather very little to no data at the beginning, but our plan is to earn people enabling this by providing extra value to people that enable this. CC @aboedo
There was a problem hiding this comment.
The fact that we are instantiating here is going to make it hard to mock. Do you think we need to mock this?
There was a problem hiding this comment.
Well, PurchasesFactory is a hard class to mock, since it's where all our real dependencies actually get instantiated. We could try to refactor this class to better separate all these dependencies and allow us to test the dependency instantiation process we do in this class, but that seems out of the scope of this PR.
6516607 to
5131dea
Compare
1f21ef7 to
a6d94a9
Compare
### Description Based on #787 This PR adds support to enable/disable diagnostics (disabled by default) and adds all the plumbing to sync diagnostics when configuring the SDK.
### Description Based on #787 This PR adds support to enable/disable diagnostics (disabled by default) and adds all the plumbing to sync diagnostics when configuring the SDK.
### Description Based on #787 This PR adds support to enable/disable diagnostics (disabled by default) and adds all the plumbing to sync diagnostics when configuring the SDK.
Description
Based on #787
This PR adds support to enable/disable diagnostics (disabled by default) and adds all the plumbing to sync diagnostics when configuring the SDK.