Diagnostics: Backend support#787
Conversation
Codecov Report
@@ Coverage Diff @@
## diagnostics #787 +/- ##
==============================================
Coverage ? 81.96%
==============================================
Files ? 127
Lines ? 4187
Branches ? 527
==============================================
Hits ? 3432
Misses ? 546
Partials ? 209 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Note that both the backend request and the file operations are executed in the same dispatcher. I believe that's ok but lmk if you have any concerns.
There was a problem hiding this comment.
Yeah that makes sense to isolate all of diagnostics in the same dispatcher.
There was a problem hiding this comment.
Yeah that makes sense to isolate all of diagnostics in the same dispatcher.
There was a problem hiding this comment.
this reminds me - we should probably add some jitter to the diagnostics call too. That way, if many apps get opened at the same time (say, from a remote push notification), we lessen the impact on our servers. We can probably have a more aggressive jitter too, compared to what we have for the rest of the calls.
There was a problem hiding this comment.
I imagine that this is to play it safe, but in practice we should never have more than one postDiagnostics request happening in the same session, let alone at the same time
There was a problem hiding this comment.
You're completely right. But yeah, this is just in case.
a6873d9 to
51d8760
Compare
62f8d66 to
0ffca29
Compare
6516607 to
5131dea
Compare
### Description Based on #787 This PR adds support to enable/disable diagnostics (disabled by default) and adds all the plumbing to sync diagnostics when configuring the SDK.
### Description Based on #787 This PR adds support to enable/disable diagnostics (disabled by default) and adds all the plumbing to sync diagnostics when configuring the SDK.
### Description Based on #787 This PR adds support to enable/disable diagnostics (disabled by default) and adds all the plumbing to sync diagnostics when configuring the SDK.
### Description Based on #787 This PR adds support to enable/disable diagnostics (disabled by default) and adds all the plumbing to sync diagnostics when configuring the SDK.
Description
Based on #785
This PR adds the logic to send diagnostics data to our backend.