Revert "Update gems"#774
Merged
Merged
Conversation
This reverts commit 3663eb4.
tonidero
approved these changes
Feb 6, 2023
| GIT | ||
| remote: https://github.com/RevenueCat/fastlane-plugin-revenuecat_internal | ||
| revision: 738f255ee8c6d4dbbb9ebdda79782ed90529e00a | ||
| revision: 92650e40d28b17899ca0cf80c8ba165931e4ab14 |
Contributor
There was a problem hiding this comment.
This moves back a couple of commits in out plugin, but I think none of those changes are critical 👍
Member
Author
There was a problem hiding this comment.
This is my latest commit so I think this moves us up 😊
Contributor
There was a problem hiding this comment.
Hmm I think this is the 3rd to last?
Member
Author
There was a problem hiding this comment.
You right lol... I'm having a Monday 🤷♂️
Codecov Report
@@ Coverage Diff @@
## main #774 +/- ##
=======================================
Coverage 81.54% 81.54%
=======================================
Files 121 121
Lines 3999 3999
Branches 512 512
=======================================
Hits 3261 3261
Misses 535 535
Partials 203 203 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
2 tasks
joshdholtz
added a commit
that referenced
this pull request
Feb 6, 2023
<!-- Thank you for contributing to Purchases! Before pressing the "Create Pull Request" button, please provide the following: --> ### Checklist - [x] If applicable, unit tests - [x] If applicable, create follow-up issues for `purchases-ios` and hybrids ### Motivation This will have `octokit` verison `4.x.x` which will make deploys work again ### Description See #774
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #765
Our CI (especially deploys) break because
octokit >= 5.x.xrequires Ruby >= 2.7 and we don't have that being used in our jobsI tried adding them using CircleCi's Ruby Orb but it
rvmfails to install newer Ruby versions due toapt-getissues 🤷♂️