Skip to content

Update gems#765

Merged
vegaro merged 2 commits into
mainfrom
update-gems
Feb 1, 2023
Merged

Update gems#765
vegaro merged 2 commits into
mainfrom
update-gems

Conversation

@vegaro

@vegaro vegaro commented Jan 31, 2023

Copy link
Copy Markdown
Member

We got some dependabot alerts of high severity vulnerabilities https://github.com/RevenueCat/purchases-android/security/dependabot

@vegaro vegaro added the pr:dependencies Changes on external dependencies label Jan 31, 2023
@vegaro vegaro requested a review from a team January 31, 2023 17:44
@codecov

codecov Bot commented Jan 31, 2023

Copy link
Copy Markdown

Codecov Report

Merging #765 (416cdc0) into main (0a3e626) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #765   +/-   ##
=======================================
  Coverage   81.54%   81.54%           
=======================================
  Files         121      121           
  Lines        3999     3999           
  Branches      512      512           
=======================================
  Hits         3261     3261           
  Misses        535      535           
  Partials      203      203           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vegaro vegaro merged commit 3663eb4 into main Feb 1, 2023
@vegaro vegaro deleted the update-gems branch February 1, 2023 01:14
@tonidero tonidero mentioned this pull request Feb 6, 2023
joshdholtz added a commit that referenced this pull request Feb 6, 2023
This reverts commit 3663eb4.
@joshdholtz joshdholtz mentioned this pull request Feb 6, 2023
joshdholtz added a commit that referenced this pull request Feb 6, 2023
Reverts #765

Our CI (especially deploys) break because `octokit >= 5.x.x` requires
Ruby >= 2.7 and we don't have that being used in our jobs

I tried adding them using CircleCi's Ruby Orb but it `rvm` fails to
install newer Ruby versions due to `apt-get` issues 🤷‍♂️
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:dependencies Changes on external dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants