Add `Purchases.logLevel` and deprecate `Purchases.debugLogsEnabled` by NachoSoto · Pull Request #753 · RevenueCat/purchases-android

NachoSoto · 2023-01-23T21:42:46Z

codecov · 2023-01-23T22:50:35Z

Codecov Report

Merging #753 (3d02288) into main (30cc1a1) will increase coverage by 0.04%.
The diff coverage is 86.95%.

@@            Coverage Diff             @@
##             main     #753      +/-   ##
==========================================
+ Coverage   81.50%   81.54%   +0.04%     
==========================================
  Files         120      121       +1     
  Lines        3984     3999      +15     
  Branches      510      512       +2     
==========================================
+ Hits         3247     3261      +14     
- Misses        534      535       +1     
  Partials      203      203

Impacted Files	Coverage Δ
...java/com/revenuecat/purchases/common/logWrapper.kt	`91.66% <0.00%> (-2.62%)`	⬇️
.../main/kotlin/com/revenuecat/purchases/Purchases.kt	`83.80% <50.00%> (+0.04%)`	⬆️
...ain/java/com/revenuecat/purchases/common/Config.kt	`100.00% <100.00%> (ø)`
...n/java/com/revenuecat/purchases/common/logUtils.kt	`93.33% <100.00%> (+4.44%)`	⬆️
...src/main/java/com/revenuecat/purchases/LogLevel.kt	`100.00% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

For [CSDK-609], [CSDK-607], [CSDK-610], [CSDK-608]. Depends on RevenueCat/purchases-android#753.

NachoSoto · 2023-01-24T01:08:06Z

Weird, this is called by tests.

I believe in the tests we are setting the Config.logLevel directly instead of going through Purchases.logLevel right?

In this case, I think it might be nice to change the tests to use these methods to make sure we cover the full flow users would use.

OMG you're right!! Thank you!
I'm gonna make it explicit instead of relying on that static import.

This code coverage thing is useful haha

Now I know not to assume it was wrong 🫢

Fixes [CSDK-607]. Depends on RevenueCat/purchases-android#753 and RevenueCat/purchases-hybrid-common#301

Fixes [CSDK-608]. Depends on RevenueCat/purchases-android#753 and RevenueCat/purchases-hybrid-common#301

tonidero

Nothing major, but I think hiding those log level methods is worth it. As for changing tests to use the Purchases accessors, it would be nice but can be done separately.

tonidero · 2023-01-24T08:45:27Z

I believe in the tests we are setting the Config.logLevel directly instead of going through Purchases.logLevel right?

In this case, I think it might be nice to change the tests to use these methods to make sure we cover the full flow users would use.

tonidero · 2023-01-24T08:50:00Z

Hmm this is accessible by devs... should we make this and the method below internal? I don't think it would help devs to have access to these.

I had to leave them as public because they're used from 2 different packages.

Ahh right 🤦 ... I really want to try to unify these modules soon.

What comes to mind is moving these 2 to the common module as extensions properties/functions. Maybe to the logUtils.kt file?

val LogLevel.debugLogsEnabled: Boolean get() = this <= LogLevel.DEBUG fun LogLevel.Companion.debugLogsEnabled(enabled: Boolean): LogLevel { return if (enabled) { LogLevel.DEBUG } else { LogLevel.INFO } }

Might need fixing some imports but they should be accessible to both the common and purchases modules once they are there and not be accessible to devs.

That works thanks 👍🏻

NachoSoto · 2023-01-25T01:16:38Z

Great feedback, thanks @tonidero. Updated!

Fixes [CSDK-549].

NachoSoto · 2023-01-25T16:38:45Z

@tonidero done.

tonidero

Looks great! 🙌

@NachoSoto

**This is an automatic release.** ### New Features * Add `Purchases.logLevel` and deprecate `Purchases.debugLogsEnabled` (#753) via NachoSoto (@NachoSoto) ### Bugfixes * Avoid syncing attributes for users with blank user ids (#755) via Toni Rico (@tonidero) ### Other Changes * Fixed Readme.MD (#727) via AristiDevs (@ArisGuimera) * Add codecov (#750) via Cesar de la Vega (@vegaro) * Update AGP to 7.4.0 (#747) via Cesar de la Vega (@vegaro) * Add test coverage using Kover (#748) via Cesar de la Vega (@vegaro) Co-authored-by: revenuecat-ops <ops@revenuecat.com> Co-authored-by: Cesar de la Vega <cesarvegaro@gmail.com> Co-authored-by: NachoSoto <ignaciosoto90@gmail.com>

Fixes [CSDK-607]. Depends on RevenueCat/purchases-android#753 and RevenueCat/purchases-hybrid-common#301

For [CSDK-609], [CSDK-607], [CSDK-610], [CSDK-608]. Depends on RevenueCat/purchases-android#753.

For [CSDK-609], [CSDK-607], [CSDK-610], [CSDK-608]. Depends on RevenueCat/purchases-android#753. [CSDK-609]: https://revenuecats.atlassian.net/browse/CSDK-609?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [CSDK-607]: https://revenuecats.atlassian.net/browse/CSDK-607?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [CSDK-610]: https://revenuecats.atlassian.net/browse/CSDK-610?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [CSDK-608]: https://revenuecats.atlassian.net/browse/CSDK-608?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

Fixes [CSDK-607]. Depends on RevenueCat/purchases-android#753 and RevenueCat/purchases-hybrid-common#301

Fixes [CSDK-608]. Depends on RevenueCat/purchases-android#753 and RevenueCat/purchases-hybrid-common#301

Fixes [CSDK-608]. Depends on RevenueCat/purchases-android#753 and RevenueCat/purchases-hybrid-common#301 [CSDK-608]: https://revenuecats.atlassian.net/browse/CSDK-608?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

- [x] Fixes [CSDK-609] - [x] Blocked by [CSDK-549] - [x] Depends on RevenueCat/purchases-hybrid-common#297 - [x] Depends on RevenueCat/purchases-android#753 - [x] Depends on RevenueCat/purchases-hybrid-common#301 [CSDK-609]: https://revenuecats.atlassian.net/browse/CSDK-609?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [CSDK-549]: https://revenuecats.atlassian.net/browse/CSDK-549?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Cesar de la Vega <cesarvegaro@gmail.com>

NachoSoto added the pr:feat A new feature label Jan 23, 2023

NachoSoto requested a review from a team January 23, 2023 21:42

NachoSoto mentioned this pull request Jan 23, 2023

Added setLogLevel RevenueCat/react-native-purchases#531

Merged

5 tasks

NachoSoto force-pushed the log-level branch from 49f39f7 to 5a478ea Compare January 23, 2023 22:31

NachoSoto added a commit to RevenueCat/purchases-hybrid-common that referenced this pull request Jan 23, 2023

Android: added CommonKt.setLogLevel

95a2496

For [CSDK-609], [CSDK-607], [CSDK-610], [CSDK-608]. Depends on RevenueCat/purchases-android#753.

NachoSoto mentioned this pull request Jan 23, 2023

Android: added CommonKt.setLogLevel RevenueCat/purchases-hybrid-common#301

Merged

NachoSoto added a commit to RevenueCat/purchases-hybrid-common that referenced this pull request Jan 24, 2023

Android: added CommonKt.setLogLevel

7681608

For [CSDK-609], [CSDK-607], [CSDK-610], [CSDK-608]. Depends on RevenueCat/purchases-android#753.

NachoSoto commented Jan 24, 2023

View reviewed changes

NachoSoto added a commit to RevenueCat/purchases-flutter that referenced this pull request Jan 24, 2023

Added Purchases.setLogLevel

edec653

Fixes [CSDK-607]. Depends on RevenueCat/purchases-android#753 and RevenueCat/purchases-hybrid-common#301

NachoSoto mentioned this pull request Jan 24, 2023

Added Purchases.setLogLevel RevenueCat/purchases-flutter#589

Merged

NachoSoto added a commit to RevenueCat/purchases-flutter that referenced this pull request Jan 24, 2023

Added Purchases.setLogLevel

ce20b89

Fixes [CSDK-607]. Depends on RevenueCat/purchases-android#753 and RevenueCat/purchases-hybrid-common#301

NachoSoto added a commit to RevenueCat/cordova-plugin-purchases that referenced this pull request Jan 24, 2023

Added Purchases.setLogLevel

8a862c2

Fixes [CSDK-608]. Depends on RevenueCat/purchases-android#753 and RevenueCat/purchases-hybrid-common#301

NachoSoto mentioned this pull request Jan 24, 2023

Added Purchases.setLogLevel RevenueCat/cordova-plugin-purchases#270

Merged

tonidero reviewed Jan 24, 2023

View reviewed changes

NachoSoto added 5 commits January 25, 2023 08:38

Add Purchases.logLevel and deprecate Purchases.debugLogsEnabled

e718cce

Fixes [CSDK-549].

Fixed PurchaseTester

45a667e

Fixed amazon build

3e24ce3

PR feedback, testing Purchases.logLevel

bca02af

Moved methods to logUtils

9f2e1b2

NachoSoto force-pushed the log-level branch from d808eed to 9f2e1b2 Compare January 25, 2023 16:38

Fixed tests

3d02288

tonidero approved these changes Jan 25, 2023

View reviewed changes

NachoSoto merged commit 4f4c575 into main Jan 25, 2023

NachoSoto deleted the log-level branch January 25, 2023 19:33

RCGitBot mentioned this pull request Jan 25, 2023

[AUTOMATIC] Release/5.7.0 #758

Merged

vegaro pushed a commit to RevenueCat/purchases-flutter that referenced this pull request Jan 26, 2023

Added Purchases.setLogLevel

75d5bb3

Fixes [CSDK-607]. Depends on RevenueCat/purchases-android#753 and RevenueCat/purchases-hybrid-common#301

NachoSoto added a commit to RevenueCat/purchases-hybrid-common that referenced this pull request Jan 26, 2023

Android: added CommonKt.setLogLevel

bd48da5

For [CSDK-609], [CSDK-607], [CSDK-610], [CSDK-608]. Depends on RevenueCat/purchases-android#753.

NachoSoto added a commit to RevenueCat/purchases-flutter that referenced this pull request Jan 27, 2023

Added Purchases.setLogLevel

31713c2

Fixes [CSDK-607]. Depends on RevenueCat/purchases-android#753 and RevenueCat/purchases-hybrid-common#301

NachoSoto added a commit to RevenueCat/cordova-plugin-purchases that referenced this pull request Jan 27, 2023

Added Purchases.setLogLevel

c1b7a04

Fixes [CSDK-608]. Depends on RevenueCat/purchases-android#753 and RevenueCat/purchases-hybrid-common#301

Uh oh!

Conversation

NachoSoto commented Jan 23, 2023 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Jan 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tonidero left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NachoSoto Jan 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NachoSoto commented Jan 25, 2023

Uh oh!

NachoSoto commented Jan 25, 2023

Uh oh!

tonidero left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NachoSoto commented Jan 23, 2023 •

edited by atlassian Bot

Loading

codecov Bot commented Jan 23, 2023 •

edited

Loading

NachoSoto Jan 25, 2023 •

edited

Loading