Added setLogLevel#531
Merged
Merged
Conversation
tonidero
reviewed
Jan 23, 2023
Member
|
I will add it to Android this week |
068ec10 to
a127550
Compare
Member
|
@NachoSoto I assigned you the Android task, since you're working on these it might be better for you to tackle that one |
c25ad13 to
1a3e96e
Compare
Fixes [CSDK-609]. Blocked by [CSDK-549].
1a3e96e to
623b352
Compare
Contributor
Author
|
This is ready! |
vegaro
approved these changes
Jan 27, 2023
|
|
||
| expect(NativeModules.RNPurchases.setLogLevel).toBeCalledWith("VERBOSE"); | ||
| expect(NativeModules.RNPurchases.setLogLevel).toBeCalledTimes(2); | ||
| }); |
Member
There was a problem hiding this comment.
I'd like to mention in case it wasn't intentional. This is only testing for Error and Verbose.
Contributor
Author
There was a problem hiding this comment.
Good point. I added tests for all levels.
Member
|
Going to merge main into this branch because my branch depends on this change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CommonFunctionality.setLogLevelpurchases-hybrid-common#297Purchases.logLeveland deprecatePurchases.debugLogsEnabledpurchases-android#753CommonKt.setLogLevelpurchases-hybrid-common#301