Skip to content

Fix predownloading of fonts if first offering doesn't have paywall components#2873

Merged
vegaro merged 1 commit into
mainfrom
cesar/fix-pre-download-of-fonts
Nov 25, 2025
Merged

Fix predownloading of fonts if first offering doesn't have paywall components#2873
vegaro merged 1 commit into
mainfrom
cesar/fix-pre-download-of-fonts

Conversation

@vegaro

@vegaro vegaro commented Nov 25, 2025

Copy link
Copy Markdown
Member

I noticed that if the first offering returned by the backend doesn't have paywall components, we were not pre-downloading the fonts. This PR should prevent that. The added test doesn't pass in main

@vegaro vegaro requested a review from a team as a code owner November 25, 2025 18:44
@vegaro vegaro requested a review from a team November 25, 2025 18:45
@codecov

codecov Bot commented Nov 25, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.25%. Comparing base (fa4c91d) to head (7c092a7).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...at/purchases/paywalls/OfferingFontPreDownloader.kt 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2873      +/-   ##
==========================================
+ Coverage   78.24%   78.25%   +0.01%     
==========================================
  Files         324      324              
  Lines       12715    12717       +2     
  Branches     1736     1736              
==========================================
+ Hits         9949     9952       +3     
  Misses       2036     2036              
+ Partials      730      729       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vegaro vegaro added this pull request to the merge queue Nov 25, 2025

@tonidero tonidero left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

Merged via the queue into main with commit 2fb536f Nov 25, 2025
23 checks passed
@vegaro vegaro deleted the cesar/fix-pre-download-of-fonts branch November 25, 2025 19:32
github-merge-queue Bot pushed a commit that referenced this pull request Nov 26, 2025
**This is an automatic release.**

> [!WARNING]  
> If you don't have any login system in your app, please make sure your
one-time purchase products have been correctly configured in the
RevenueCat dashboard as either consumable or non-consumable. If they're
incorrectly configured as consumables, RevenueCat will consume these
purchases. This means that users won't be able to restore them from
version 9.0.0 onward.
> Non-consumables are products that are meant to be bought only once,
for example, lifetime subscriptions.


## RevenueCatUI SDK
### 🐞 Bugfixes
* Fix ANR when initializing FontLoader (#2819) via Cesar de la Vega
(@vegaro)
### Paywallv2
#### 🐞 Bugfixes
* Fix `Template7CustomPackagesTestData` (#2875) via Cesar de la Vega
(@vegaro)
* Fix predownloading of fonts if first offering doesn't have paywall
components (#2873) via Cesar de la Vega (@vegaro)

### 🔄 Other Changes
* Extract parameters for non paid revenue tracking API to use objects
(#2871) via Toni Rico (@tonidero)
* Bump fastlane from 2.229.0 to 2.229.1 (#2869) via dependabot[bot]
(@dependabot[bot])

Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants