Extract parameters for non paid revenue tracking API to use objects#2871
Merged
Conversation
polmiro
approved these changes
Nov 26, 2025
tonidero
commented
Nov 26, 2025
| */ | ||
| @InternalRevenueCatAPI | ||
| @Poko | ||
| class AdDisplayedData( |
Contributor
Author
There was a problem hiding this comment.
I did wonder about adding a builder for all of these... But maybe it's ok for now since the parameters are pretty simple IMO. We can add it later if it's needed I guess
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2871 +/- ##
==========================================
+ Coverage 78.25% 78.28% +0.03%
==========================================
Files 325 330 +5
Lines 12732 12753 +21
Branches 1739 1739
==========================================
+ Hits 9963 9984 +21
Misses 2038 2038
Partials 731 731 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Nov 26, 2025
**This is an automatic release.** > [!WARNING] > If you don't have any login system in your app, please make sure your one-time purchase products have been correctly configured in the RevenueCat dashboard as either consumable or non-consumable. If they're incorrectly configured as consumables, RevenueCat will consume these purchases. This means that users won't be able to restore them from version 9.0.0 onward. > Non-consumables are products that are meant to be bought only once, for example, lifetime subscriptions. ## RevenueCatUI SDK ### 🐞 Bugfixes * Fix ANR when initializing FontLoader (#2819) via Cesar de la Vega (@vegaro) ### Paywallv2 #### 🐞 Bugfixes * Fix `Template7CustomPackagesTestData` (#2875) via Cesar de la Vega (@vegaro) * Fix predownloading of fonts if first offering doesn't have paywall components (#2873) via Cesar de la Vega (@vegaro) ### 🔄 Other Changes * Extract parameters for non paid revenue tracking API to use objects (#2871) via Toni Rico (@tonidero) * Bump fastlane from 2.229.0 to 2.229.1 (#2869) via dependabot[bot] (@dependabot[bot]) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up from #2728
In iOS, we're passing an object to the track methods for non paid revenue tracking, but we were passing the individual parameters in Android. After thinking about it, passing an object allows for better extensibility, so modifying the API for android.
This is technically a breaking change, but the API is still internal, so it should be ok.