Improves button progress indicator size calculation.#2485
Merged
Conversation
tonidero
approved these changes
Jul 4, 2025
tonidero
left a comment
Contributor
There was a problem hiding this comment.
Just one question, but not really a blocker, thanks for fixing this!! 🙏
| minDimensionDp >= 24.dp -> minDimensionDp - 16.dp | ||
| minDimensionDp >= 16.dp -> 8.dp | ||
| minDimensionDp >= 8.dp -> minDimensionDp - 8.dp | ||
| else -> 0.dp |
Contributor
There was a problem hiding this comment.
hopefully devs won't have buttons as small, but better to handle it yeah 😅
Member
Author
There was a problem hiding this comment.
Haha yea, maybe really small icon buttons? 😅
📸 Snapshot Test648 unchanged
🛸 Powered by Emerge Tools |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2485 +/- ##
=======================================
Coverage 78.72% 78.72%
=======================================
Files 289 289
Lines 10519 10519
Branches 1509 1509
=======================================
Hits 8281 8281
Misses 1590 1590
Partials 648 648 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 9, 2025
**This is an automatic release.** ## RevenueCat SDK ### ✨ New Features * feat(purchases): Add setPostHogUserId() method to Purchases API (#2495) via Hussain Mustafa (@hussain-mustafa990) ### 🐞 Bugfixes * Improves button progress indicator size calculation. (#2485) via JayShortway (@JayShortway) ### 🔄 Other Changes * Revert "BC8 migration (#2477)" (#2501) via Toni Rico (@tonidero) * Add codelab instructions on README file (#2489) via Jaewoong Eum (@skydoves) * Use collectAsStateWithLifecycle instead of collectAsState in Compose (#2488) via Jaewoong Eum (@skydoves) * Improve Composable stabilities (#2478) via Jaewoong Eum (@skydoves) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2486) via RevenueCat Git Bot (@RCGitBot) * BC8 migration (#2477) via Toni Rico (@tonidero) * Fixes building sample apps with SNAPSHOT dependencies (#2483) via JayShortway (@JayShortway) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2484) via RevenueCat Git Bot (@RCGitBot) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
No longer makes the progress indicator as big as the button itself. Dynamically calculates some padding, and sets a maximum size.
With artificially long loading time:
progress.mov