BC8 migration by tonidero · Pull Request #2477 · RevenueCat/purchases-android

tonidero · 2025-07-01T14:05:16Z

Description

Migrates to BC8: https://developer.android.com/google/play/billing/release-notes#8-0-0

codecov · 2025-07-01T14:58:32Z

Codecov Report

Attention: Patch coverage is 60.52632% with 30 lines in your changes missing coverage. Please review.

Project coverage is 78.33%. Comparing base (0eee76f) to head (d9606cd).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...hases/google/usecase/QueryProductDetailsUseCase.kt	17.64%	12 Missing and 2 partials ⚠️
.../com/revenuecat/purchases/google/BillingWrapper.kt	75.00%	8 Missing ⚠️
...n/kotlin/com/revenuecat/purchases/google/errors.kt	70.00%	4 Missing and 2 partials ⚠️
...n/com/revenuecat/purchases/amazon/AmazonBilling.kt	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2477      +/-   ##
==========================================
- Coverage   78.72%   78.33%   -0.39%     
==========================================
  Files         289      286       -3     
  Lines       10519    10432      -87     
  Branches     1509     1500       -9     
==========================================
- Hits         8281     8172     -109     
- Misses       1590     1614      +24     
+ Partials      648      646       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tonidero · 2025-07-01T15:12:26Z

    ) {
        log(LogIntent.DEBUG) { RestoreStrings.QUERYING_PURCHASE_WITH_TYPE.format(productId, productType.name) }
-        queryAllPurchases(
+        queryPurchases(


This is a change in behavior in Amazon... but I think this is fine, since this method was only used for upgrades/downgrades which is not really supported in Amazon. I just changed the implementation to make it more sense with the new method name.

Is there any way to test this?

Well, as you can see here, we early exit from the purchase if the developer gives us any replacement information (we actually should improve that, since it would actually keep the call forever without returning an error 😬)

Ouch, yea that's something we should improve. Can be a separate PR though.

tonidero · 2025-07-01T15:14:20Z

+            StatusCode.INVALID_PRODUCT_ID_FORMAT -> "INVALID_PRODUCT_ID_FORMAT"
+            StatusCode.NO_ELIGIBLE_OFFER -> "NO_ELIGIBLE_OFFER"
+            else -> "UNKNOWN_STATUS_CODE: $statusCode"
+        }


This was interesting, for now I'm just logging to console, but in the future it might be useful to track this information with diagnostics or something else and expose it in the dashboard in case there are issues.

This might be a fun interview problem 😅

tonidero · 2025-07-01T17:07:55Z


+    // Google Play Billing Library 8.0 removed APIs to query historical purchases.
+    // This method will from now on only return active purchases in Google Play.
+    // However, in Amazon, it will still return historical purchases.


TBH, I wasn't sure whether to just remove this method entirely... but I wanted to keep Amazon having the same functionality as long as it's possible and since this is abstracting the Store, I preferred to keep it. Lmk if you think otherwise.

Might be good to make this actual documentation of the method, so it's surfaced by the IDE?

/** * Google Play Billing Library 8.0 removed APIs to query historical purchases. * This method will from now on only return active purchases in Google Play. * However, in Amazon, it will still return historical purchases. */

…c8-migration

tonidero · 2025-07-02T07:39:59Z


    @SuppressWarnings("LongParameterList")
-    abstract fun findPurchaseInPurchaseHistory(
+    abstract fun findPurchaseInActivePurchases(


This was only being used for upgrades/downgrades. I'm not sure why were were looking in the purchase history, when upgrades/downgrades are only possible with active subs AFAIK. Now we only check for active purchases.

JayShortway

Thanks for taking care of this! Approved as far as I'm concerned, but since this is pretty much the change of the year, we might want another pair of eyes on it.

JayShortway · 2025-07-02T10:48:59Z

- * **Important**: until multi-line subscriptions are released,
- * we assume that there will be only a single sku in the purchase.
- * https://android-developers.googleblog.com/2021/05/whats-new-in-google-play-2021.html


Well well well 😅

4 years later...

JayShortway · 2025-07-02T11:18:47Z

+            StatusCode.INVALID_PRODUCT_ID_FORMAT -> "INVALID_PRODUCT_ID_FORMAT"
+            StatusCode.NO_ELIGIBLE_OFFER -> "NO_ELIGIBLE_OFFER"
+            else -> "UNKNOWN_STATUS_CODE: $statusCode"
+        }


This might be a fun interview problem 😅

JayShortway · 2025-07-02T11:21:04Z


+    // Google Play Billing Library 8.0 removed APIs to query historical purchases.
+    // This method will from now on only return active purchases in Google Play.
+    // However, in Amazon, it will still return historical purchases.


Might be good to make this actual documentation of the method, so it's surfaced by the IDE?

/** * Google Play Billing Library 8.0 removed APIs to query historical purchases. * This method will from now on only return active purchases in Google Play. * However, in Amazon, it will still return historical purchases. */

JayShortway · 2025-07-02T11:21:53Z

    ) {
        log(LogIntent.DEBUG) { RestoreStrings.QUERYING_PURCHASE_WITH_TYPE.format(productId, productType.name) }
-        queryAllPurchases(
+        queryPurchases(


Is there any way to test this?

ajpallares

Took a look. Nothing to object! But I'll leave approval to others with more knowledge 🙏

vegaro · 2025-07-04T09:11:06Z

-
    override fun queryAllPurchases(
        appUserID: String,
        onReceivePurchaseHistory: (List<StoreTransaction>) -> Unit,


Maybe these parameters names should be updated.

I wonder if queryAllPurchases can just be queryPurchases now as well

Right, I left queryAllPurchases as it is... The thing is that Amazon can still query for all products, so I think restore/sync should still do that in Amazon. In that case, we need to differentiate between both... (I guess we could also unify both methods and add a parameter, but I kept it separate for now to minimize the changes and left a comment as seen here

vegaro · 2025-07-04T09:12:59Z

-            )
-        } catch (e: NoClassDefFoundError) {
-            throw NoCoreLibraryDesugaringException(e)
-        }


did they finally fix this?

Yup! I was able to test on the device we used to test the issues. Very easy to repro in main. No issues with BC8 🙌

vegaro · 2025-07-04T09:18:17Z

+        .firstOrNull { it.getInt(it) == this }
+        ?.name
+        ?: "$this"
+}


I assume getOnPurchasesUpdatedSubResponseCodeName will barely get called but since it's using reflection, you could maybe create a static map that this function can access when called

Well, it will get called on every purchase attempt... And yeah, might be better to create a map... I just followed what we do for the responseCode itself, but I think creating a map ourselves feels better yeah... Will do the change, and I might change that other mapping we do while I'm at it.

vegaro · 2025-07-04T09:19:58Z

        }
-        logErrorIfIssueBuildingBillingParams(received)
-        received.takeUnless { it.isEmpty() }?.forEach {
+        received.unfetchedProductList.takeIf { it.isNotEmpty() }?.let {


oh this unfetchedProductList is nice

We could have somthing similar in Offerings

Yeah, we might want to expose this somehow... But we should probably agree on what API to use. For now, I'm just logging the reason for it to be unfetched, but I also think it might be good to track it with diagnostics, and even give this information in the dashboard.

This reverts commit 2270d6a.

tonidero · 2025-07-09T16:44:47Z

Removing breaking label since we're making a new release without this for now, so automations are able to continue and make a normal release before we ship this. Reverted in #2501

@hussain-mustafa990

**This is an automatic release.** ## RevenueCat SDK ### ✨ New Features * feat(purchases): Add setPostHogUserId() method to Purchases API (#2495) via Hussain Mustafa (@hussain-mustafa990) ### 🐞 Bugfixes * Improves button progress indicator size calculation. (#2485) via JayShortway (@JayShortway) ### 🔄 Other Changes * Revert "BC8 migration (#2477)" (#2501) via Toni Rico (@tonidero) * Add codelab instructions on README file (#2489) via Jaewoong Eum (@skydoves) * Use collectAsStateWithLifecycle instead of collectAsState in Compose (#2488) via Jaewoong Eum (@skydoves) * Improve Composable stabilities (#2478) via Jaewoong Eum (@skydoves) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2486) via RevenueCat Git Bot (@RCGitBot) * BC8 migration (#2477) via Toni Rico (@tonidero) * Fixes building sample apps with SNAPSHOT dependencies (#2483) via JayShortway (@JayShortway) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2484) via RevenueCat Git Bot (@RCGitBot) Co-authored-by: revenuecat-ops <ops@revenuecat.com>

This reverts commit 34c61a3. ### Description Reapplies the changes originally from #2477 that were reverted in #2501 to allow making a release in the current major. Migrates to BC8: https://developer.android.com/google/play/billing/release-notes#8-0-0

BC8 migration

371351a

tonidero added pr:breaking Changes that are breaking pr:other labels Jul 1, 2025

Improve logs for unfetched products

f1507ac

Make amazon also only return active subs for replacing old subs

c4ca441

tonidero commented Jul 1, 2025

View reviewed changes

tonidero added 3 commits July 1, 2025 17:34

More cleanup

b7867cd

Some more small naming cleanup

5541e61

More cleanup

864bb13

tonidero commented Jul 1, 2025

View reviewed changes

tonidero added 4 commits July 1, 2025 19:17

And some more cleanup

ffaa883

Merge branch 'main' of github.com:RevenueCat/purchases-android into b…

76a9301

…c8-migration

Add logs for billing flow onPurchasesUpdated subResponseCode

1762954

Fix linter

b314c2d

tonidero commented Jul 2, 2025

View reviewed changes

tonidero and others added 2 commits July 2, 2025 09:45

Do not log if there are no missing products

1b978fb

Merge branch 'main' into bc8-migration

180b8c0

tonidero marked this pull request as ready for review July 2, 2025 07:45

tonidero requested review from a team and vegaro July 2, 2025 07:46

Fix detekt

54a655c

JayShortway reviewed Jul 2, 2025

View reviewed changes

Change to docstring

8c0c6e2

ajpallares reviewed Jul 2, 2025

View reviewed changes

Remove unnecessary NoCoreLibraryDesugaringException

2f55a5d

vegaro reviewed Jul 4, 2025

View reviewed changes

vegaro approved these changes Jul 4, 2025

View reviewed changes

Do not use reflection for billing client codes. Instead map the codes

a7b03a2

tonidero and others added 2 commits July 4, 2025 13:01

Update metalava

d4f4c34

Merge branch 'main' into bc8-migration

8e24fa2

tonidero enabled auto-merge July 4, 2025 11:02

tonidero added this pull request to the merge queue Jul 4, 2025

MarkVillacampa approved these changes Jul 4, 2025

View reviewed changes

tonidero removed this pull request from the merge queue due to a manual request Jul 4, 2025

Improved docs for syncPurchases and restorePurchases

9b35fcd

tonidero enabled auto-merge July 4, 2025 12:05

More improvements to docs

d9606cd

tonidero added this pull request to the merge queue Jul 4, 2025

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 4, 2025

tonidero added this pull request to the merge queue Jul 4, 2025

Merged via the queue into main with commit 2270d6a Jul 4, 2025
14 checks passed

tonidero deleted the bc8-migration branch July 4, 2025 14:20

tonidero added a commit that referenced this pull request Jul 9, 2025

Revert "BC8 migration (#2477)"

b4a3b2a

This reverts commit 2270d6a.

tonidero removed the pr:breaking Changes that are breaking label Jul 9, 2025

tonidero added a commit that referenced this pull request Jul 9, 2025

Revert "BC8 migration (#2477)" (#2501)

34c61a3

RCGitBot mentioned this pull request Jul 9, 2025

[AUTOMATIC] Release/8.22.0 #2502

Merged

tonidero mentioned this pull request Jul 10, 2025

BC8 migration #2506

Merged

Uh oh!

Conversation

tonidero commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

codecov Bot commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JayShortway left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ajpallares left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tonidero commented Jul 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tonidero commented Jul 1, 2025 •

edited

Loading

codecov Bot commented Jul 1, 2025 •

edited

Loading