[Paywalls V2] Norwegian Bokmål and Norwegian Nynorsk fall back to Norwegian.#2329
Merged
Conversation
JayShortway
commented
Apr 4, 2025
Comment on lines
+272
to
+287
| arrayOf( | ||
| "no-NO -> no-NO", | ||
| Args( | ||
| paywallLocales = nonEmptyListOf("en_US", "no_NO"), | ||
| deviceLocales = nonEmptyListOf("no-NO", "en-US"), | ||
| expected = "no-NO", | ||
| ), | ||
| ), | ||
| arrayOf( | ||
| "no-NO -> no", | ||
| Args( | ||
| paywallLocales = nonEmptyListOf("en_US", "no"), | ||
| deviceLocales = nonEmptyListOf("no-NO", "en-US"), | ||
| expected = "no", | ||
| ), | ||
| ), |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2329 +/- ##
=======================================
Coverage 80.11% 80.11%
=======================================
Files 282 282
Lines 10028 10028
Branches 1421 1421
=======================================
Hits 8034 8034
Misses 1379 1379
Partials 615 615 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tonidero
approved these changes
Apr 4, 2025
tonidero
left a comment
Contributor
There was a problem hiding this comment.
Just a question, but since I think it's probably not allowed, we should be good. Thanks for fixing!
| arrayOf( | ||
| "no-NO -> no-NO", | ||
| Args( | ||
| paywallLocales = nonEmptyListOf("en_US", "no_NO"), |
Contributor
There was a problem hiding this comment.
Probably not possible but just in case, can the paywall locale also have a nb or nn locale? If so, might be worth adding some test cases for that. We might need to implement a circular fallback system in that case 😅
Member
Author
There was a problem hiding this comment.
Yea, it's indeed not possible right now. I went to implement the fallback anyway just in case, but I don't think we should. no is a fallback for nb and nn, but I don't think the same is true the other way around. If a device is set to no, but the paywall has nb (hypothetically), I'm not sure we should be serving the nb localized paywall.
auto-merge was automatically disabled
April 7, 2025 09:56
Pull Request is not mergeable
This was referenced Apr 8, 2025
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 15, 2025
**This is an automatic release.** ## RevenueCat SDK ### 🐞 Bugfixes * Add missing response fields to `CustomerInfo`. Including transaction Prices (#2128) via Cesar de la Vega (@vegaro) ## RevenueCatUI SDK ### Paywallv2 #### 🐞 Bugfixes * [Paywalls v2] Fixes timeline layout when width is Fit (#2354) via JayShortway (@JayShortway) * [Paywalls V2] Improves fuzzy matching locale when the region doesn't match (#2355) via JayShortway (@JayShortway) * [Paywalls V2] Norwegian Bokmål and Norwegian Nynorsk fall back to Norwegian. (#2329) via JayShortway (@JayShortway) ### Customer Center #### 🐞 Bugfixes * Clean up on restoring functionality in customer center (#2316) via Cesar de la Vega (@vegaro) ### 🔄 Other Changes * [Paywalls v2] Adds the unsupported Background type to the error message (#2350) via JayShortway (@JayShortway) * [Paywalls v2] Uses a fixed date for template previews to avoid daily changes. (#2351) via JayShortway (@JayShortway) * [Paywalls v2] Adds a default case to `Background` and `ButtonComponent` (#2347) via JayShortway (@JayShortway) * [Paywalls v2] Improves `PaywallComponentsTemplatePreviewRecorder` stability (#2352) via JayShortway (@JayShortway) * [Paywalls v2] Adds a default case to most enums and sealed types (#2346) via JayShortway (@JayShortway) * Adds `EnumDeserializerWithDefault` and `SealedDeserializerWithDefault` (#2345) via JayShortway (@JayShortway) * [Paywalls V2] Renders template previews in a fixed resolution using Paparazzi (#2214) via JayShortway (@JayShortway) * Bump fastlane from 2.227.0 to 2.227.1 (#2344) via dependabot[bot] (@dependabot[bot]) * Migrate root gradle file to KTS (#2343) via Jaewoong Eum (@skydoves) * Migrate tester modules to KTS format (#2340) via Jaewoong Eum (@skydoves) * Introduce purchases-bom package (#2339) via Jaewoong Eum (@skydoves) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2338) via RevenueCat Git Bot (@RCGitBot) * [Diagnostics] Removes Android 7 requirement (#2335) via JayShortway (@JayShortway) * [Paywalls v2] Fixes `update-paywall-preview-resources-submodule` CI job (#2337) via JayShortway (@JayShortway) * Make purchases module to transitive dependency for the ui module (#2334) via Jaewoong Eum (@skydoves) * Migrate settings.gradle to KTS and add the dependency resolutions (#2328) via Jaewoong Eum (@skydoves) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
When the device is set to
nbornn, the paywall should pick thenolocalization. This was not happening.