Add missing response fields to `CustomerInfo`. Including transaction Prices by vegaro · Pull Request #2128 · RevenueCat/purchases-android

vegaro · 2025-02-07T17:53:50Z

This pull request introduces several enhancements and new features to the SubscriptionInfo and related classes in the purchases module. The most important changes include adding new properties to the SubscriptionInfo class, creating a new PriceResponse class, and updating the SubscriptionInfoResponse class to include additional fields.

Enhancements to `SubscriptionInfo` and related classes:

purchases/src/main/kotlin/com/revenuecat/purchases/SubscriptionInfo.kt:
- Added new properties autoResumeDate, displayName, price, and productPlanIdentifier to the SubscriptionInfo class. [1] [2]
- Added a locale parameter to the constructor of SubscriptionInfo, for building the price
purchases/src/main/kotlin/com/revenuecat/purchases/common/responses/PriceResponse.kt:
- Created a new PriceResponse class to handle price-related information.
purchases/src/main/kotlin/com/revenuecat/purchases/common/responses/SubscriptionInfoResponse.kt:
- Updated the SubscriptionInfoResponse class to include autoResumeDate, displayName, price, and productPlanIdentifier fields. [1] [2]
purchases/src/main/kotlin/com/revenuecat/purchases/models/Transaction.kt:
- Added new properties displayName, isSandbox, originalPurchaseDate, and price to the Transaction class. [1] [2]

Additional updates:

purchases/src/main/kotlin/com/revenuecat/purchases/utils/PriceExtensions.kt:
- Changed the visibility of MICRO_MULTIPLIER to internal.

codecov · 2025-02-11T16:29:08Z

Codecov Report

Attention: Patch coverage is 37.50000% with 50 lines in your changes missing coverage. Please review.

Project coverage is 80.12%. Comparing base (3f11b50) to head (8857a25).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...otlin/com/revenuecat/purchases/SubscriptionInfo.kt	22.22%	27 Missing and 1 partial ⚠️
...lin/com/revenuecat/purchases/models/Transaction.kt	45.83%	12 Missing and 1 partial ⚠️
...hases/common/responses/SubscriptionInfoResponse.kt	47.05%	8 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2128      +/-   ##
==========================================
- Coverage   80.34%   80.12%   -0.23%     
==========================================
  Files         281      282       +1     
  Lines        9964    10026      +62     
  Branches     1417     1421       +4     
==========================================
+ Hits         8006     8033      +27     
- Misses       1346     1378      +32     
- Partials      612      615       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tonidero

Mostly just some comments to avoid the breaking changes but looking good!

vegaro · 2025-04-04T12:03:17Z

checking the tests now

tonidero

Left some comments but nothing really blocking. Thanks for adding this!

tonidero · 2025-04-04T11:58:33Z

+
+    @OptIn(ExperimentalSerializationApi::class)
+    @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE)
+    internal val json = Json {


We've talked in the past that we should try to unify these into a single Json instance with a single configuration, so serializing is consistent accross models... Maybe we could extract the OfferingParser json instance and use that one? I see this one has explicitNulls set to false, but I would assume that should be fine even if the same thing happens for Offerings?

We can probably also do this in a separate PR, but feels like something we should try to move towards soon.

tonidero · 2025-04-04T11:59:37Z

+
+    internal companion object {
+        @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE)
+        internal val json = Json {


Same thing about the json instance. I think ideally we only add at most one for CustomerInfo data (but preferable use the same as other parts of the SDK).

Did that in a9da840 (#2128)

Thanks for the idea!

tonidero

Thanks for doing those changes!

@vegaro

**This is an automatic release.** ## RevenueCat SDK ### 🐞 Bugfixes * Add missing response fields to `CustomerInfo`. Including transaction Prices (#2128) via Cesar de la Vega (@vegaro) ## RevenueCatUI SDK ### Paywallv2 #### 🐞 Bugfixes * [Paywalls v2] Fixes timeline layout when width is Fit (#2354) via JayShortway (@JayShortway) * [Paywalls V2] Improves fuzzy matching locale when the region doesn't match (#2355) via JayShortway (@JayShortway) * [Paywalls V2] Norwegian Bokmål and Norwegian Nynorsk fall back to Norwegian. (#2329) via JayShortway (@JayShortway) ### Customer Center #### 🐞 Bugfixes * Clean up on restoring functionality in customer center (#2316) via Cesar de la Vega (@vegaro) ### 🔄 Other Changes * [Paywalls v2] Adds the unsupported Background type to the error message (#2350) via JayShortway (@JayShortway) * [Paywalls v2] Uses a fixed date for template previews to avoid daily changes. (#2351) via JayShortway (@JayShortway) * [Paywalls v2] Adds a default case to `Background` and `ButtonComponent` (#2347) via JayShortway (@JayShortway) * [Paywalls v2] Improves `PaywallComponentsTemplatePreviewRecorder` stability (#2352) via JayShortway (@JayShortway) * [Paywalls v2] Adds a default case to most enums and sealed types (#2346) via JayShortway (@JayShortway) * Adds `EnumDeserializerWithDefault` and `SealedDeserializerWithDefault` (#2345) via JayShortway (@JayShortway) * [Paywalls V2] Renders template previews in a fixed resolution using Paparazzi (#2214) via JayShortway (@JayShortway) * Bump fastlane from 2.227.0 to 2.227.1 (#2344) via dependabot[bot] (@dependabot[bot]) * Migrate root gradle file to KTS (#2343) via Jaewoong Eum (@skydoves) * Migrate tester modules to KTS format (#2340) via Jaewoong Eum (@skydoves) * Introduce purchases-bom package (#2339) via Jaewoong Eum (@skydoves) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2338) via RevenueCat Git Bot (@RCGitBot) * [Diagnostics] Removes Android 7 requirement (#2335) via JayShortway (@JayShortway) * [Paywalls v2] Fixes `update-paywall-preview-resources-submodule` CI job (#2337) via JayShortway (@JayShortway) * Make purchases module to transitive dependency for the ui module (#2334) via Jaewoong Eum (@skydoves) * Migrate settings.gradle to KTS and add the dependency resolutions (#2328) via Jaewoong Eum (@skydoves) Co-authored-by: revenuecat-ops <ops@revenuecat.com>

vegaro force-pushed the cc-328-add-prices-to-customerinfo-transactions branch from 120a014 to c9eec4e Compare February 11, 2025 13:21

vegaro added the pr:fix A bug fix label Feb 11, 2025

vegaro marked this pull request as ready for review February 11, 2025 15:33

facumenzella reviewed Feb 13, 2025

View reviewed changes

Comment thread purchases/src/main/kotlin/com/revenuecat/purchases/SubscriptionInfo.kt Outdated

Comment thread purchases/src/main/kotlin/com/revenuecat/purchases/common/responses/PriceResponse.kt Outdated

vegaro requested a review from a team March 3, 2025 11:15

vegaro force-pushed the cc-328-add-prices-to-customerinfo-transactions branch from 68c0085 to 88a7c06 Compare March 3, 2025 11:17

tonidero reviewed Mar 3, 2025

View reviewed changes

vegaro added 6 commits April 4, 2025 13:31

add missing response fields to CustomerInfo

8a55d2d

add price info

f728246

JvmSynthetic

593e1ae

fix nullability and toString

b8c4ae6

fix tests and other fixes

3502f11

PaywallViewModelTest

8f498c2

vegaro force-pushed the cc-328-add-prices-to-customerinfo-transactions branch from 88a7c06 to 8f498c2 Compare April 4, 2025 11:31

vegaro added 4 commits April 4, 2025 13:36

better docs

04846b5

create constructor to prevent breaking changes

108e8d3

make PriceResponse a data class

9457f17

deprecated constructors

3a01b4a

vegaro requested review from facumenzella and tonidero April 4, 2025 11:49

tonidero approved these changes Apr 4, 2025

View reviewed changes

vegaro added 3 commits April 4, 2025 14:17

api tests

5aaa841

SubscriptionInfoResponse.PriceResponse

0925436

move MICRO_MULTIPLIER

74e7af4

vegaro force-pushed the cc-328-add-prices-to-customerinfo-transactions branch from 5345286 to 74e7af4 Compare April 4, 2025 13:40

vegaro added 3 commits April 4, 2025 16:19

tests with paused sub

4608087

extract json deserializer

a9da840

Merge branch 'main' into cc-328-add-prices-to-customerinfo-transactions

8857a25

vegaro requested a review from tonidero April 4, 2025 15:33

vegaro added this pull request to the merge queue Apr 4, 2025

vegaro removed this pull request from the merge queue due to a manual request Apr 4, 2025

tonidero approved these changes Apr 4, 2025

View reviewed changes

vegaro added this pull request to the merge queue Apr 4, 2025

Merged via the queue into main with commit b085d62 Apr 4, 2025

vegaro deleted the cc-328-add-prices-to-customerinfo-transactions branch April 4, 2025 16:52

This was referenced Apr 8, 2025

[DO NOT MERGE] Release/8.16.1 #2341

Closed

[AUTOMATIC] Release/8.16.1 #2349

Closed

[AUTOMATIC] Release/8.16.1 #2359

Merged

Uh oh!

Conversation

vegaro commented Feb 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Enhancements to SubscriptionInfo and related classes:

Additional updates:

Uh oh!

codecov Bot commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

tonidero left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vegaro commented Apr 4, 2025

Uh oh!

tonidero left a comment

Choose a reason for hiding this comment

Uh oh!

tonidero Apr 4, 2025

Choose a reason for hiding this comment

Uh oh!

tonidero Apr 4, 2025

Choose a reason for hiding this comment

Uh oh!

vegaro Apr 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tonidero left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vegaro commented Feb 7, 2025 •

edited

Loading

Enhancements to `SubscriptionInfo` and related classes:

codecov Bot commented Feb 11, 2025 •

edited

Loading