Add onManagementOptionSelected to CustomerCenterListener#2270
Merged
Conversation
📸 Snapshot Test13 modified, 379 unchanged
🛸 Powered by Emerge Tools |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2270 +/- ##
==========================================
- Coverage 80.31% 80.27% -0.05%
==========================================
Files 278 279 +1
Lines 9489 9494 +5
Branches 1337 1337
==========================================
Hits 7621 7621
- Misses 1308 1313 +5
Partials 560 560 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JayShortway
reviewed
Mar 19, 2025
JayShortway
left a comment
Member
There was a problem hiding this comment.
Looking good! Just making sure sealed is what we want.
| /** | ||
| * Sealed interface representing different customer center management options. | ||
| */ | ||
| sealed interface CustomerCenterManagementOption { |
Member
There was a problem hiding this comment.
Just making sure that using sealed is a conscious decision? What are we going to do when adding an *Option? The alternative would be to drop the sealed:
Suggested change
| sealed interface CustomerCenterManagementOption { | |
| interface CustomerCenterManagementOption { |
Member
Author
There was a problem hiding this comment.
oh right... I added it so it could be used in when but yeah, same problems as with the enums when adding a new one. Good point
Member
There was a problem hiding this comment.
A regular interface can also be used in a when, but the else is mandatory in that case.
JayShortway
approved these changes
Mar 19, 2025
JayShortway
left a comment
Member
There was a problem hiding this comment.
Thanks for making the changes!
…/PurchasesAPI.kt Co-authored-by: JayShortway <29483617+JayShortway@users.noreply.github.com>
JayShortway
approved these changes
Mar 19, 2025
This was referenced Mar 19, 2025
vegaro
pushed a commit
that referenced
this pull request
Mar 19, 2025
**This is an automatic release.** ## RevenueCatUI SDK ### 🐞 Bugfixes * Fix landscape mode in Paywalls v1 Template 3 (#2265) via Josh Holtz (@joshdholtz) ### Customer Center #### ✨ New Features * feat: Introduce `CustomerCenterView` for hybrid usage (#2170) via Cesar de la Vega (@vegaro) * Add `onManagementOptionSelected` to `CustomerCenterListener` (#2270) via Cesar de la Vega (@vegaro) ### Paywallv2 #### 🐞 Bugfixes * [Paywalls V2] Ignores missing font alias if it's blank. (#2271) via JayShortway (@JayShortway) * [Paywalls V2] Fixes badges not being overriden (#2266) via JayShortway (@JayShortway) ### 🔄 Other Changes * [Diagnostics] Add play_store_version and play_services_version to all google events (#2269) via Toni Rico (@tonidero) * [Diagnostics] Add `id` and `app_session_id` to events (#2268) via Toni Rico (@tonidero) * Uploads Paparazzi screenshots to Emerge. (#2232) via JayShortway (@JayShortway) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Equivalent of https://github.com/RevenueCat/purchases-ios/pull/4872/files adding a listener that gets triggered as soon as an option is selected