Skip to content

[Diagnostics] Add id and app_session_id to events#2268

Merged
tonidero merged 1 commit into
mainfrom
diagnostics-add-event-id-app-session-id
Mar 19, 2025
Merged

[Diagnostics] Add id and app_session_id to events#2268
tonidero merged 1 commit into
mainfrom
diagnostics-add-event-id-app-session-id

Conversation

@tonidero

@tonidero tonidero commented Mar 18, 2025

Copy link
Copy Markdown
Contributor

Description

This adds some new properties to diagnostics so we're able to better track events and what happens within the same session.

It also adds a small refactor to DiagnosticsTracker track events to avoid repetition to pass the app session id.

@tonidero tonidero marked this pull request as ready for review March 18, 2025 15:35
@tonidero tonidero requested a review from a team March 18, 2025 15:35
@emerge-tools

emerge-tools Bot commented Mar 18, 2025

Copy link
Copy Markdown

📸 Snapshot Test

4 modified, 388 unchanged

Name Added Removed Modified Renamed Unchanged Errored Approval
TestPurchasesUIAndroidCompatibility
com.revenuecat.testpurchasesuiandroidcompatibility
0 0 4 0 260 0 ⏳ Needs approval
TestPurchasesUIAndroidCompatibility Paparazzi
com.revenuecat.testpurchasesuiandroidcompatibility.paparazzi
0 0 0 0 128 0 N/A

🛸 Powered by Emerge Tools

@codecov

codecov Bot commented Mar 18, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 93.22034% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.30%. Comparing base (24ac437) to head (db9171e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...purchases/common/diagnostics/DiagnosticsTracker.kt 92.72% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2268      +/-   ##
==========================================
+ Coverage   80.28%   80.30%   +0.01%     
==========================================
  Files         278      278              
  Lines        9484     9483       -1     
  Branches     1336     1336              
==========================================
+ Hits         7614     7615       +1     
+ Misses       1310     1308       -2     
  Partials      560      560              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JayShortway JayShortway left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@ajpallares ajpallares left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tonidero tonidero merged commit fb33fa4 into main Mar 19, 2025
@tonidero tonidero deleted the diagnostics-add-event-id-app-session-id branch March 19, 2025 09:43
This was referenced Mar 19, 2025
vegaro pushed a commit that referenced this pull request Mar 19, 2025
**This is an automatic release.**

## RevenueCatUI SDK
### 🐞 Bugfixes
* Fix landscape mode in Paywalls v1 Template 3 (#2265) via Josh Holtz
(@joshdholtz)
### Customer Center
#### ✨ New Features
* feat: Introduce `CustomerCenterView` for hybrid usage (#2170) via
Cesar de la Vega (@vegaro)
* Add `onManagementOptionSelected` to `CustomerCenterListener` (#2270)
via Cesar de la Vega (@vegaro)
### Paywallv2
#### 🐞 Bugfixes
* [Paywalls V2] Ignores missing font alias if it's blank. (#2271) via
JayShortway (@JayShortway)
* [Paywalls V2] Fixes badges not being overriden (#2266) via JayShortway
(@JayShortway)

### 🔄 Other Changes
* [Diagnostics] Add play_store_version and play_services_version to all
google events (#2269) via Toni Rico (@tonidero)
* [Diagnostics] Add `id` and `app_session_id` to events (#2268) via Toni
Rico (@tonidero)
* Uploads Paparazzi screenshots to Emerge. (#2232) via JayShortway
(@JayShortway)

Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants