[CustomerCenter] Fix help path deserializing when unknown type#1869
Merged
Conversation
JayShortway
approved these changes
Oct 4, 2024
JayShortway
left a comment
Member
There was a problem hiding this comment.
Ah yes, this is a frequent annoyance with collections + kotlinx.serialization. Thanks for taking care of it, much better!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1869 +/- ##
==========================================
+ Coverage 82.37% 82.41% +0.03%
==========================================
Files 225 226 +1
Lines 7900 7915 +15
Branches 1104 1105 +1
==========================================
+ Hits 6508 6523 +15
+ Misses 953 952 -1
- Partials 439 440 +1 ☔ View full report in Codecov by Sentry. |
JayShortway
pushed a commit
that referenced
this pull request
Oct 10, 2024
**This is an automatic release.** ## RevenueCat SDK ### 🐞 Bugfixes * Save SDK configuration on paywall activity so it can reconfigure automatically (#1872) via Toni Rico (@tonidero) ### 📦 Dependency Updates * Bump fastlane from 2.223.1 to 2.224.0 (#1870) via dependabot[bot] (@dependabot[bot]) * Bump fastlane-plugin-revenuecat_internal from `5b2e35c` to `3b1e7cf` (#1865) via dependabot[bot] (@dependabot[bot]) * Bump fastlane from 2.222.0 to 2.223.1 (#1860) via dependabot[bot] (@dependabot[bot]) * Bump fastlane-plugin-revenuecat_internal from `55a0455` to `5b2e35c` (#1858) via dependabot[bot] (@dependabot[bot]) ### 🔄 Other Changes * [CustomerCenter] Fix help path deserializing when unknown type (#1869) via Toni Rico (@tonidero) * [CustomerCenter] Create `CustomerCenter` composable and view model with some initial UI (#1867) via Toni Rico (@tonidero) * [CustomerCenter] Add networking layer and models (#1859) via Toni Rico (@tonidero) * [CustomerCenter] Adds SubscriptionDetailsView (#1863) via JayShortway (@JayShortway) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While testing one thing I noticed we were not handling unknown help path types. This basically caused the whole screen to not be deserialized, since we catch deserialization issues at that level, but we can do better than that and just not deserialize the unknown path type.